From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org,
Guoqing Jiang <guoqing.jiang@cloud.ionos.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
drbd-dev@lists.linbit.com
Subject: [PATCH RFC 1/5] block: return ns precision from disk_start_io_acct
Date: Wed, 8 Jul 2020 09:58:15 +0200 [thread overview]
Message-ID: <20200708075819.4531-2-guoqing.jiang@cloud.ionos.com> (raw)
In-Reply-To: <20200708075819.4531-1-guoqing.jiang@cloud.ionos.com>
Currently the duration accounting of bio based driver is converted from
jiffies to ns, means it could be less accurate as request based driver.
So let disk_start_io_acct return from ns precision, instead of convert
jiffies to ns in disk_end_io_acct.
Cc: Philipp Reisner <philipp.reisner@linbit.com>
Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
Cc: drbd-dev@lists.linbit.com
Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
---
block/blk-core.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index d9d632639bd1..0e806a8c62fb 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -1466,6 +1466,7 @@ unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
struct hd_struct *part = &disk->part0;
const int sgrp = op_stat_group(op);
unsigned long now = READ_ONCE(jiffies);
+ unsigned long start_ns = ktime_get_ns();
part_stat_lock();
update_io_ticks(part, now, false);
@@ -1474,7 +1475,7 @@ unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
part_stat_local_inc(part, in_flight[op_is_write(op)]);
part_stat_unlock();
- return now;
+ return start_ns;
}
EXPORT_SYMBOL(disk_start_io_acct);
@@ -1484,11 +1485,11 @@ void disk_end_io_acct(struct gendisk *disk, unsigned int op,
struct hd_struct *part = &disk->part0;
const int sgrp = op_stat_group(op);
unsigned long now = READ_ONCE(jiffies);
- unsigned long duration = now - start_time;
+ unsigned long duration = ktime_get_ns() - start_time;
part_stat_lock();
update_io_ticks(part, now, true);
- part_stat_add(part, nsecs[sgrp], jiffies_to_nsecs(duration));
+ part_stat_add(part, nsecs[sgrp], duration);
part_stat_local_dec(part, in_flight[op_is_write(op)]);
part_stat_unlock();
}
--
2.17.1
next prev parent reply other threads:[~2020-07-08 7:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 7:58 [RFC PATCH 0/4] block: add two statistic tables Guoqing Jiang
2020-07-08 7:58 ` Guoqing Jiang [this message]
2020-07-08 13:27 ` [PATCH RFC 1/5] block: return ns precision from disk_start_io_acct Ming Lei
2020-07-08 13:53 ` Guoqing Jiang
2020-07-08 17:46 ` Guoqing Jiang
2020-07-08 7:58 ` [PATCH RFC 2/5] drbd: remove unused argument from drbd_request_prepare and __drbd_make_request Guoqing Jiang
2020-07-08 7:58 ` [PATCH RFC 3/5] drbd: rename start_jif to start_ns Guoqing Jiang
2020-07-08 7:58 ` [PATCH RFC 4/5] block: add a statistic table for io latency Guoqing Jiang
2020-07-08 13:29 ` Ming Lei
2020-07-08 14:02 ` Guoqing Jiang
2020-07-08 14:06 ` Guoqing Jiang
2020-07-09 18:48 ` Guoqing Jiang
2020-07-10 0:53 ` Ming Lei
2020-07-10 8:55 ` Guoqing Jiang
2020-07-10 10:00 ` Ming Lei
2020-07-10 10:29 ` Guoqing Jiang
2020-07-11 1:32 ` Ming Lei
2020-07-12 20:39 ` Guoqing Jiang
2020-07-12 20:44 ` Jens Axboe
2020-07-12 21:04 ` Guoqing Jiang
2020-07-10 14:04 ` Jens Axboe
2020-07-08 7:58 ` [PATCH RFC 5/5] block: add a statistic table for io sector Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708075819.4531-2-guoqing.jiang@cloud.ionos.com \
--to=guoqing.jiang@cloud.ionos.com \
--cc=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox