public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: John Garry <john.garry@huawei.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V2] blk-mq: streamline handling of q->mq_ops->queue_rq result
Date: Thu, 9 Jul 2020 06:03:17 +0800	[thread overview]
Message-ID: <20200708220317.GA3348426@T590> (raw)
In-Reply-To: <90d57d37-6da9-cae4-55b0-264c3dd885b0@huawei.com>

On Wed, Jul 08, 2020 at 03:05:03PM +0100, John Garry wrote:
> On 08/07/2020 13:27, Ming Lei wrote:
> > k;
> > -		} else if (ret == BLK_STS_ZONE_RESOURCE) {
> > +		case BLK_STS_RESOURCE:
> > +		case BLK_STS_DEV_RESOURCE:
> > +			blk_mq_handle_dev_resource(rq, list);
> > +			goto out;
> > +		case BLK_STS_ZONE_RESOURCE:
> >   			/*
> >   			 * Move the request to zone_list and keep going through
> >   			 * the dispatch list to find more requests the drive can
> 
> question not on this patch specifically: is this supposed to be "driver",
> and not "drive"? "driver" is mentioned earlier in the function

Hi John,

Please focus on change added by this patch instead of existed context code.

If you have question on existed code, start a new thread for the discussion.

Thanks,
Ming


  parent reply	other threads:[~2020-07-08 22:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 13:58 [PATCH V2] blk-mq: streamline handling of q->mq_ops->queue_rq result Ming Lei
2020-07-08 12:27 ` Ming Lei
2020-07-08 12:53   ` Johannes Thumshirn
2020-07-08 14:05   ` John Garry
2020-07-08 14:23     ` Johannes Thumshirn
2020-07-08 22:03     ` Ming Lei [this message]
2020-07-08 22:05 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200708220317.GA3348426@T590 \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=john.garry@huawei.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox