Re: [PATCH] blk-mq: centralise related handling into blk_mq_get_driver_tag

[Ming Lei <ming.lei@redhat.com>]

On Wed, Jul 08, 2020 at 03:07:05PM +0100, John Garry wrote:
> On 07/07/2020 08:16, Ming Lei wrote:
> > On Tue, Jul 07, 2020 at 07:37:41AM +0100, John Garry wrote:
> > > On 06/07/2020 15:41, Ming Lei wrote:
> > > > -	hctx = flush_rq->mq_hctx;
> > > >    	if (!q->elevator) {
> > > 
> > > Is there a specific reason we do:
> > > 
> > > if (!a)
> > > 	do x
> > > else
> > > 	do y
> > > 
> > > as opposed to:
> > > 
> > > if (a)
> > > 	do y
> > > else
> > > 	do x
> > > 
> > > Do people find this easier to read or more obvious? Just wondering.
> > 
> > If you like the style, please go ahead to switch to this way.
> > 
> 
> Maybe I will, but I'll try to hunt down more cases first.

You are reviewing existed context code instead of this patch!!!

One more time, please focus on change added by this patch.

Thanks,
Ming