From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19ECCC433DF for ; Fri, 10 Jul 2020 08:23:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDF5A206A5 for ; Fri, 10 Jul 2020 08:23:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726369AbgGJIXH (ORCPT ); Fri, 10 Jul 2020 04:23:07 -0400 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:53011 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbgGJIXH (ORCPT ); Fri, 10 Jul 2020 04:23:07 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R341e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0U2GtUMy_1594369384; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0U2GtUMy_1594369384) by smtp.aliyun-inc.com(127.0.0.1); Fri, 10 Jul 2020 16:23:04 +0800 Date: Fri, 10 Jul 2020 16:23:04 +0800 From: Baolin Wang To: axboe@kernel.dk Cc: ming.lei@redhat.com, baolin.wang7@gmail.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed_request() Message-ID: <20200710082304.GB29262@VM20190228-100.tbsite.net> Reply-To: Baolin Wang References: <969d0e9f637b2a0dbfb3d284abfbed6fc7665ea4.1593846855.git.baolin.wang7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <969d0e9f637b2a0dbfb3d284abfbed6fc7665ea4.1593846855.git.baolin.wang7@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi, On Sat, Jul 04, 2020 at 03:28:21PM +0800, Baolin Wang wrote: > We've already validated the 'q->elevator' before calling ->ops.completed_request() > in blk_mq_sched_completed_request(), thus no need to validate rq->internal_tag again, > and remove it. A gentle ping? > > Signed-off-by: Baolin Wang > --- > block/blk-mq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index abcf590f6238..78572b2e1675 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -550,8 +550,7 @@ inline void __blk_mq_end_request(struct request *rq, blk_status_t error) > blk_stat_add(rq, now); > } > > - if (rq->internal_tag != BLK_MQ_NO_TAG) > - blk_mq_sched_completed_request(rq, now); > + blk_mq_sched_completed_request(rq, now); > > blk_account_io_done(rq, now); > > -- > 2.17.1