Re: [PATCH RFC v7 12/12] hpsa: enable host_tagset and switch to MQ

John Garry
2020-07-14T09:55:22Z

On 14/07/2020 09:06, Ming Lei wrote:
>> v7 is here:
>>
>> https://github.com/hisilicon/kernel-dev/commits/private-topic-blk-mq-shared-tags-rfc-v7
>>
>> So that should be good to test with for now.
>>
>> And I was going to ask this same question about smartpqi, so can you please
>> let me know about this one?

Hi Ming,

> smartpqi is real MQ HBA, do you need any change wrt. shared tags?

Is it really?

As I see, today it maintains a single tagset per HBA. So Hannes' change
in this series seems ok. However, I do worry that mainline code may be
wrong, as block layer may send can_queue * nr_hw_queues requests, when
it seems the HBA can only handle can_queue requests.

Thanks,
john