Re: [PATCH RFC v7 12/12] hpsa: enable host_tagset and switch to MQ

John Garry
2020-08-04T09:29:53Z

On 03/08/2020 21:39, Don.Brace@microchip.com wrote:

Hi Don,

>>> at should be good to test with for now.
> clonedhttps://github.com/hisilicon/kernel-dev
> branch origin/private-topic-blk-mq-shared-tags-rfc-v7
>
> The driver did not load, so I cherry-picked from
>
> git://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
> branch origin/reserved-tags.v6
>
> the following patches:
> 6a9d1a96ea41 hpsa: move hpsa_hba_inquiry after scsi_add_host()
> eeb5cd1fca58 hpsa: use reserved commands
> 7df7d8382902 hpsa: use scsi_host_busy_iter() to traverse outstanding commands
> 485881d6d8dc hpsa: drop refcount field from CommandList
> c4980ad5e5cb scsi: implement reserved command handling
> 34d03fa945c0 scsi: add scsi_{get,put}_internal_cmd() helper
> 4556e50450c8 block: add flag for internal commands
> 138125f74b25 scsi: hpsa: Lift {BIG_,}IOCTL_Command_struct copy{in,out} into hpsa_ioctl()
> cb17c1b69b17 scsi: hpsa: Don't bother with vmalloc for BIG_IOCTL_Command_struct
> 10100ffd5f65 scsi: hpsa: Get rid of compat_alloc_user_space()
> 06b43f968db5 scsi: hpsa: hpsa_ioctl(): Tidy up a bit
>
> The driver loads and I ran some mke2fs, mount/umount tests,

ok, great

> but I am getting an extra devices in the list which does not
> seem to be coming from hpsa driver.
>
> I have not yet had time to diagnose this issue.
>
> lsscsi
> [1:0:0:0] disk ASMT 2105 0 /dev/sdi
> [14:0:-1:0] type??? nullnull nullnullnullnull null -
> [14:0:0:0] storage HP H240 7.19 -
> [14:0:1:0] disk ATA MB002000GWFGH HPG0 /dev/sda
> [14:0:2:0] disk ATA MB002000GWFGH HPG0 /dev/sdb
> [14:0:3:0] disk HP EF0450FARMV HPD5 /dev/sdc
> [14:0:4:0] disk ATA MB002000GWFGH HPG0 /dev/sdd
> [14:0:5:0] disk ATA MB002000GWFGH HPG0 /dev/sde
> [14:0:6:0] disk HP EF0450FARMV HPD5 /dev/sdf
> [14:0:7:0] disk ATA VB0250EAVER HPG7 /dev/sdg
> [14:0:8:0] disk ATA MB0500GCEHF HPGC /dev/sdh
> [14:0:9:0] enclosu HP H240 7.19 -
> [15:0:-1:0] type??? nullnull nullnullnullnull null -
> [15:0:0:0] storage HP P440 7.19 -
> [15:1:0:0] disk HP LOGICAL VOLUME 7.19 /dev/sdj
> [15:1:0:1] disk HP LOGICAL VOLUME 7.19 /dev/sdk
> [15:1:0:2] disk HP LOGICAL VOLUME 7.19 /dev/sdl
> [15:1:0:3] disk HP LOGICAL VOLUME 7.19 /dev/sdm
> [16:0:-1:0] type??? nullnull nullnullnullnull null -
> [16:0:0:0] storage HP P441 7.19 -
>
>

I assume that you are missing some other patches from that branch, like
these:

77dcb92c31ae scsi: revamp host device handling
6e9884aefe66 scsi: Use dummy inquiry data for the host device
a381637f8a6e scsi: use real inquiry data when initialising devices

@Hannes, Any plans to get this series going again?

Thanks,
John