From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D128DC433DF for ; Mon, 17 Aug 2020 07:56:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B64D220772 for ; Mon, 17 Aug 2020 07:56:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726265AbgHQH43 (ORCPT ); Mon, 17 Aug 2020 03:56:29 -0400 Received: from mga18.intel.com ([134.134.136.126]:62698 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726089AbgHQH42 (ORCPT ); Mon, 17 Aug 2020 03:56:28 -0400 IronPort-SDR: Q1kXtXqJdmQggvM2jQNZh21ddspQAT1gfb08JkKlFx3OLeowNxsuvsIosIYj9P6OXa9jRyHS5L Ayg8HJ76EdVg== X-IronPort-AV: E=McAfee;i="6000,8403,9715"; a="142279040" X-IronPort-AV: E=Sophos;i="5.76,322,1592895600"; d="scan'208";a="142279040" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2020 00:56:27 -0700 IronPort-SDR: GIV0e/9tzlgXRX2LtHPbhmGQ2CMRs69Hd8rw2avnvcnBmzE/cTsA1VRPY2bJ74sbvq8ueoMHo+ 5+7zQN0U0KLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,322,1592895600"; d="scan'208";a="440790871" Received: from lkp-server02.sh.intel.com (HELO 2f0d8b563e65) ([10.239.97.151]) by orsmga004.jf.intel.com with ESMTP; 17 Aug 2020 00:56:25 -0700 Received: from kbuild by 2f0d8b563e65 with local (Exim 4.92) (envelope-from ) id 1k7a0H-0000QX-Ax; Mon, 17 Aug 2020 07:56:25 +0000 Date: Mon, 17 Aug 2020 15:55:59 +0800 From: kernel test robot To: Baolin Wang , axboe@kernel.dk Cc: kbuild-all@lists.01.org, ming.lei@redhat.com, hch@lst.de, baolin.wang@linux.alibaba.com, baolin.wang7@gmail.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] block: fix boolconv.cocci warnings Message-ID: <20200817075559.GA149398@7edacc24721b> References: <5b932aa51fc2b46c381d7b83d591a6ddbf05b199.1597637287.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b932aa51fc2b46c381d7b83d591a6ddbf05b199.1597637287.git.baolin.wang@linux.alibaba.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org From: kernel test robot block/blk-mq-sched.c:404:39-44: WARNING: conversion to bool not needed here Remove unneeded conversion to bool Semantic patch information: Relational and logical operators evaluate to bool, explicit conversion is overly verbose and unneeded. Generated by: scripts/coccinelle/misc/boolconv.cocci CC: Baolin Wang Signed-off-by: kernel test robot --- url: https://github.com/0day-ci/linux/commits/Baolin-Wang/Some-clean-ups-for-bio-merge/20200817-121114 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next Please take the patch only if it's a positive warning. Thanks! blk-mq-sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/block/blk-mq-sched.c +++ b/block/blk-mq-sched.c @@ -401,7 +401,7 @@ bool blk_mq_bio_list_merge(struct reques if (merge == BIO_MERGE_NONE) continue; - return merge == BIO_MERGE_OK ? true: false; + return merge == BIO_MERGE_OK; } return false;