From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
Christoph Hellwig <hch@lst.de>,
Changpeng Liu <changpeng.liu@intel.com>,
Daniel Verkamp <dverkamp@chromium.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>
Subject: [PATCH V3 0/3] block: fix discard merge for single max discard segment
Date: Mon, 17 Aug 2020 17:52:38 +0800 [thread overview]
Message-ID: <20200817095241.2494763-1-ming.lei@redhat.com> (raw)
Hello,
The 1st patch checks max discard segment limit in request merge code,
and one discard request failure is fixed for virtio_blk.
The 2nd patch fixes handling of single max discard segment for virtio_blk,
and potential memory corruption is fixed.
The 3rd patch renames the confusing blk_discard_mergable().
The biggest problem is that virtio_blk handles discard request in
multi-range style, however it(at least qemu) may claim that multi range
discard isn't supported by returning 1 for max discard segment.
V3:
- one patch style change in patch 1, as suggested by Christoph
- add reviewed-by tag
V2:
- add comment
- warn on mismatched bios and discard segment number
- rename blk_discard_mergable
Ming Lei (3):
block: respect queue limit of max discard segment
block: virtio_blk: fix handling single range discard request
block: rename blk_discard_mergable as blk_discard_support_multi_range
block/blk-merge.c | 22 ++++++++++++++++------
drivers/block/virtio_blk.c | 31 +++++++++++++++++++++++--------
2 files changed, 39 insertions(+), 14 deletions(-)
Cc: Christoph Hellwig <hch@lst.de>
Cc: Changpeng Liu <changpeng.liu@intel.com>
Cc: Daniel Verkamp <dverkamp@chromium.org>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Stefano Garzarella <sgarzare@redhat.com>
--
2.25.2
next reply other threads:[~2020-08-17 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 9:52 Ming Lei [this message]
2020-08-17 9:52 ` [PATCH V3 1/3] block: respect queue limit of max discard segment Ming Lei
2020-08-17 9:52 ` [PATCH V3 2/3] block: virtio_blk: fix handling single range discard request Ming Lei
2020-08-18 13:52 ` Stefan Hajnoczi
2020-08-17 9:52 ` [PATCH V3 3/3] block: rename blk_discard_mergable as blk_discard_support_multi_range Ming Lei
2020-08-17 10:14 ` Christoph Hellwig
2020-08-17 14:00 ` [PATCH V3 0/3] block: fix discard merge for single max discard segment Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817095241.2494763-1-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=changpeng.liu@intel.com \
--cc=dverkamp@chromium.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox