From: Christoph Hellwig <hch@infradead.org>
To: Ritika Srivastava <ritika.srivastava@oracle.com>
Cc: linux-block@vger.kernel.org, axboe@kernel.dk,
martin.petersen@oracle.com, hch@infradead.org
Subject: Re: [PATCH v4 2/2] block: better deal with the delayed not supported case in blk_cloned_rq_check_limits
Date: Tue, 18 Aug 2020 20:43:21 +0100 [thread overview]
Message-ID: <20200818194321.GA3271@infradead.org> (raw)
In-Reply-To: <1597772380-3034-1-git-send-email-ritika.srivastava@oracle.com>
On Tue, Aug 18, 2020 at 10:39:40AM -0700, Ritika Srivastava wrote:
> If WRITE_ZERO/WRITE_SAME operation is not supported by the storage,
> blk_cloned_rq_check_limits() will return IO error which will cause
> device-mapper to fail the paths.
>
> Instead, if the queue limit is set to 0, return BLK_STS_NOTSUPP.
> BLK_STS_NOTSUPP will be ignored by device-mapper and will not fail the
> paths.
>
> Suggested-by: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: Ritika Srivastava <ritika.srivastava@oracle.com>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-08-18 19:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 17:39 [PATCH v4 2/2] block: better deal with the delayed not supported case in blk_cloned_rq_check_limits Ritika Srivastava
2020-08-18 19:43 ` Christoph Hellwig [this message]
2020-08-26 17:03 ` Ritika Srivastava
-- strict thread matches above, loose matches on Subject: below --
2020-09-01 20:17 Return BLK_STS_NOTSUPP and blk_status_t from blk_cloned_rq_check_limits() Ritika Srivastava
2020-09-01 20:17 ` [PATCH v4 2/2] block: better deal with the delayed not supported case in blk_cloned_rq_check_limits Ritika Srivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818194321.GA3271@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ritika.srivastava@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).