Re: [PATCH V3 4/4] nvme: use blk_mq_[un]quiesce_tagset

Hannes Reinecke
2020-09-08T08:46:30Z

On 9/8/20 10:15 AM, Ming Lei wrote:
> From: Sagi Grimberg <sagi@grimberg.me>
>
> All controller namespaces share the same tagset, so we
> can use this interface which does the optimal operation
> for parallel quiesce based on the tagset type (e.g.
> blocking tagsets and non-blocking tagsets).
>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Bart Van Assche <bvanassche@acm.org>
> Cc: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
> Cc: Chao Leng <lengchao@huawei.com>
>
> Add code to unquiesce ctrl->connect_q in nvme_stop_queues(), meantime
> avoid to call blk_mq_quiesce_tagset()/blk_mq_unquiesce_tagset() if
> this tagset isn't initialized.
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> drivers/nvme/host/core.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer