From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Bart Van Assche <bvanassche@acm.org>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Hannes Reinecke <hare@suse.de>, Chao Leng <lengchao@huawei.com>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V5 0/4] blk-mq: implement queue quiesce via percpu_ref for BLK_MQ_F_BLOCKING
Date: Mon, 14 Sep 2020 11:05:42 +0800 [thread overview]
Message-ID: <20200914030542.GA342981@T590> (raw)
In-Reply-To: <D4DF8CEF-AFFE-4EE1-947F-D9500007C7A0@kernel.dk>
On Fri, Sep 11, 2020 at 01:14:29PM -0600, Jens Axboe wrote:
> On Sep 11, 2020, at 1:12 PM, Sagi Grimberg <sagi@grimberg.me> wrote:
> >
> >
> >>> Hi Jens,
> >>>
> >>> The 1st patch add .mq_quiesce_mutex for serializing quiesce/unquiesce,
> >>> and prepares for replacing srcu with percpu_ref.
> >>>
> >>> The 2nd patch replaces srcu with percpu_ref.
> >>>
> >>> The 3rd patch adds tagset quiesce interface.
> >>>
> >>> The 4th patch applies tagset quiesce interface for NVMe subsystem.
> >> What is this series against?
> >
> > It didn't apply cleanly to me too until I realized it is
> > on top of v4 of: "percpu_ref & block: reduce memory footprint of percpu_ref in fast path"
>
> Right, and that’s what has the leak issue you found. I’ll hold off on this one until that’s sorted.
Actually this patchset doesn't depend on patch of 'percpu_ref & block: reduce memory
footprint of percpu_ref in fast path', and I hold them in one branch, so
causes the conflict.
V6 has been sent out, and just rebase against for-5.10/block directly.
Thanks,
Ming
prev parent reply other threads:[~2020-09-14 3:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 2:41 [PATCH V5 0/4] blk-mq: implement queue quiesce via percpu_ref for BLK_MQ_F_BLOCKING Ming Lei
2020-09-11 2:41 ` [PATCH V5 1/4] block: use test_and_{clear|test}_bit to set/clear QUEUE_FLAG_QUIESCED Ming Lei
2020-09-11 6:03 ` Hannes Reinecke
2020-09-11 2:41 ` [PATCH V5 2/4] blk-mq: implement queue quiesce via percpu_ref for BLK_MQ_F_BLOCKING Ming Lei
2020-09-11 2:41 ` [PATCH V5 3/4] blk-mq: add tagset quiesce interface Ming Lei
2020-09-11 2:41 ` [PATCH V5 4/4] nvme: use blk_mq_[un]quiesce_tagset Ming Lei
2020-09-11 17:29 ` [PATCH V5 0/4] blk-mq: implement queue quiesce via percpu_ref for BLK_MQ_F_BLOCKING Sagi Grimberg
2020-09-11 18:34 ` Sagi Grimberg
2020-09-11 18:45 ` Jens Axboe
2020-09-11 23:28 ` Ming Lei
2020-09-11 17:33 ` Keith Busch
2020-09-11 18:05 ` Jens Axboe
2020-09-11 19:12 ` Sagi Grimberg
2020-09-11 19:14 ` Jens Axboe
2020-09-14 3:05 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914030542.GA342981@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).