From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Borislav Petkov <bp@suse.de>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH v3 2/2] scsi: Fix ZBC disk initialization
Date: Tue, 15 Sep 2020 16:16:02 +0100 [thread overview]
Message-ID: <20200915151602.GB1266@infradead.org> (raw)
In-Reply-To: <20200915073347.832424-3-damien.lemoal@wdc.com>
On Tue, Sep 15, 2020 at 04:33:47PM +0900, Damien Le Moal wrote:
> Make sure to call sd_zbc_init_disk() when the sdkp->zoned field is
> known, that is, once sd_read_block_characteristics() is executed in
> sd_revalidate_disk(), so that host-aware disks also get initialized.
> To do so, move sd_zbc_init_disk() call in sd_zbc_revalidate_zones() and
> make sure to execute it for all zoned disks, including for host-aware
> disks used as regular disks as these disk zoned model may be changed
> back to BLK_ZONED_HA when partitions are deleted.
>
> Reported-by: Borislav Petkov <bp@alien8.de>
> Fixes: 5795eb443060 ("scsi: sd_zbc: emulate ZONE_APPEND commands")
> Cc: <stable@vger.kernel.org> # v5.8+
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> Tested-by: Borislav Petkov <bp@suse.de>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-09-15 15:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 7:33 [PATCH v3 0/2] Fix handling of host-aware ZBC disks Damien Le Moal
2020-09-15 7:33 ` [PATCH v3 1/2] scsi: " Damien Le Moal
2020-09-15 15:13 ` Christoph Hellwig
2020-09-15 15:20 ` Johannes Thumshirn
2020-09-17 15:53 ` Sasha Levin
2020-09-17 23:50 ` Damien Le Moal
2020-09-18 6:04 ` Greg KH
2020-09-15 7:33 ` [PATCH v3 2/2] scsi: Fix ZBC disk initialization Damien Le Moal
2020-09-15 15:16 ` Christoph Hellwig [this message]
2020-09-16 0:09 ` [PATCH v3 0/2] Fix handling of host-aware ZBC disks Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915151602.GB1266@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bp@suse.de \
--cc=damien.lemoal@wdc.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).