From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Leon Romanovsky <leon@kernel.org>, Christoph Hellwig <hch@lst.de>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>, Jens Axboe <axboe@kernel.dk>,
Keith Busch <kbusch@kernel.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH blk-next 1/2] blk-mq-rdma: Delete not-used multi-queue RDMA map queue code
Date: Fri, 2 Oct 2020 08:45:05 +0200 [thread overview]
Message-ID: <20201002064505.GA9593@lst.de> (raw)
In-Reply-To: <879916e4-b572-16b9-7b92-94dba7e918a3@grimberg.me>
On Tue, Sep 29, 2020 at 11:24:49AM -0700, Sagi Grimberg wrote:
> Yes, basically usage of managed affinity caused people to report
> regressions not being able to change irq affinity from procfs.
Well, why would they change it? The whole point of the infrastructure
is that there is a single sane affinity setting for a given setup. Now
that setting needed some refinement from the original series (e.g. the
current series about only using housekeeping cpus if cpu isolation is
in use). But allowing random users to modify affinity is just a receipe
for a trainwreck.
So I think we need to bring this back ASAP, as doing affinity right
out of the box is an absolute requirement for sane performance without
all the benchmarketing deep magic.
next prev parent reply other threads:[~2020-10-02 6:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 9:13 [PATCH blk-next 0/2] Delete the get_vector_affinity leftovers Leon Romanovsky
2020-09-29 9:13 ` [PATCH blk-next 1/2] blk-mq-rdma: Delete not-used multi-queue RDMA map queue code Leon Romanovsky
2020-09-29 10:20 ` Christoph Hellwig
2020-09-29 10:35 ` Leon Romanovsky
2020-09-29 18:24 ` Sagi Grimberg
2020-10-02 6:45 ` Christoph Hellwig [this message]
2020-10-02 20:20 ` Sagi Grimberg
2020-10-05 8:38 ` Christoph Hellwig
2020-10-06 4:58 ` Leon Romanovsky
2020-09-29 9:13 ` [PATCH blk-next 2/2] RDMA/core: Delete not-implemented get_vector_affinity Leon Romanovsky
2020-10-01 5:01 ` [PATCH blk-next 0/2] Delete the get_vector_affinity leftovers Leon Romanovsky
2020-10-02 1:28 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002064505.GA9593@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=kbusch@kernel.org \
--cc=leon@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).