From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Rui Salvaterra <rsalvaterra@gmail.com>
Cc: minchan@kernel.org, ngupta@vflare.org,
sergey.senozhatsky.work@gmail.com, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH v3] zram: break the strict dependency from lzo
Date: Tue, 27 Oct 2020 10:22:04 +0900 [thread overview]
Message-ID: <20201027012204.GD2412725@google.com> (raw)
In-Reply-To: <20201026085141.1179-1-rsalvaterra@gmail.com>
On (20/10/26 08:51), Rui Salvaterra wrote:
> static const char * const backends[] = {
> +#if IS_ENABLED(CONFIG_CRYPTO_LZO)
> "lzo",
> "lzo-rle",
> +#endif
> #if IS_ENABLED(CONFIG_CRYPTO_LZ4)
> "lz4",
> #endif
[..]
> +static const char *default_compressor =
> +#if IS_ENABLED(CONFIG_CRYPTO_LZO)
> + "lzo-rle";
> +#elif IS_ENABLED(CONFIG_CRYPTO_LZ4)
> + "lz4";
> +#elif IS_ENABLED(CONFIG_CRYPTO_LZ4HC)
> + "lz4hc";
> +#elif IS_ENABLED(CONFIG_CRYPTO_842)
> + "842";
> +#elif IS_ENABLED(CONFIG_CRYPTO_ZSTD)
> + "zstd";
> +#endif
Honestly, I'm not entirely excited. lzo is a fallback compression
algorithm. If you want to use zram with something else thenconfigure
zram to use something else. What do all these #if/#elif buy us?
-ss
next prev parent reply other threads:[~2020-10-27 1:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 8:51 [PATCH v3] zram: break the strict dependency from lzo Rui Salvaterra
2020-10-27 1:22 ` Sergey Senozhatsky [this message]
2020-10-27 8:39 ` Rui Salvaterra
2020-10-28 10:19 ` Sergey Senozhatsky
2020-10-28 11:25 ` Rui Salvaterra
2020-10-28 18:21 ` Sergey Senozhatsky
2020-10-28 23:11 ` Rui Salvaterra
2020-10-29 1:29 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027012204.GD2412725@google.com \
--to=sergey.senozhatsky.work@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=rsalvaterra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).