From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Rui Salvaterra <rsalvaterra@gmail.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
minchan@kernel.org, ngupta@vflare.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v3] zram: break the strict dependency from lzo
Date: Thu, 29 Oct 2020 03:21:58 +0900 [thread overview]
Message-ID: <20201028182158.GA128655@google.com> (raw)
In-Reply-To: <CALjTZvaTiAS1vMyrTNvrfy7KOjemy+tW5-hbTy5SHYfsbRE=_Q@mail.gmail.com>
Hi,
On (20/10/28 11:25), Rui Salvaterra wrote:
> > diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig
> > index fe7a4b7d30cf..f93eed40e155 100644
> > --- a/drivers/block/zram/Kconfig
> > +++ b/drivers/block/zram/Kconfig
> > @@ -2,7 +2,7 @@
> > config ZRAM
> > tristate "Compressed RAM block device support"
> > depends on BLOCK && SYSFS && ZSMALLOC && CRYPTO
> > - select CRYPTO_LZO
> > + depends on (CRYPTO_LZO || CRYPTO_LZ4 || CRYPTO_LZ4HC || CRYPTO_842 || CRYPTO_ZSTD)
>
> This reverses the dependency order, as now we have to select a
> supported compression algorithm in order for zram to be visible in the
> block device drivers list.
Right, but well we also need to select ZSMALLOC and CRYPTO for
zram to become visible (the thing that I found out recently is
that you can always check the hidden/blocked items by hitting
'z' in menuconfig).
> This is why I wrote the ZRAM_AUTOSEL_ALGO
> kconfig symbol, which automatically selects lzo as a fallback. If the
> user chooses to select another supported algorithm, he will then be
> allowed to deselect lzo. We thus follow the principle of least
> surprise, IMHO.
OK, makes sense.
-ss
next prev parent reply other threads:[~2020-10-28 22:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 8:51 [PATCH v3] zram: break the strict dependency from lzo Rui Salvaterra
2020-10-27 1:22 ` Sergey Senozhatsky
2020-10-27 8:39 ` Rui Salvaterra
2020-10-28 10:19 ` Sergey Senozhatsky
2020-10-28 11:25 ` Rui Salvaterra
2020-10-28 18:21 ` Sergey Senozhatsky [this message]
2020-10-28 23:11 ` Rui Salvaterra
2020-10-29 1:29 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028182158.GA128655@google.com \
--to=sergey.senozhatsky.work@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=rsalvaterra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).