* [PATCH] nbd: fix a block_device refcount leak in nbd_release
@ 2020-11-09 17:30 Christoph Hellwig
2020-11-09 18:02 ` Josef Bacik
2020-11-10 15:01 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-11-09 17:30 UTC (permalink / raw)
To: josef; +Cc: linux-block, nbd
bdget_disk needs to be paired with bdput to not leak a reference
on the block device inode.
Fixes: 08ba91ee6e2c ("nbd: Add the nbd NBD_DISCONNECT_ON_CLOSE config flag.")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/block/nbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index a6f51934391edb..45b0423ef2c53d 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -1493,6 +1493,7 @@ static void nbd_release(struct gendisk *disk, fmode_t mode)
if (test_bit(NBD_RT_DISCONNECT_ON_CLOSE, &nbd->config->runtime_flags) &&
bdev->bd_openers == 0)
nbd_disconnect_and_put(nbd);
+ bdput(bdev);
nbd_config_put(nbd);
nbd_put(nbd);
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nbd: fix a block_device refcount leak in nbd_release
2020-11-09 17:30 [PATCH] nbd: fix a block_device refcount leak in nbd_release Christoph Hellwig
@ 2020-11-09 18:02 ` Josef Bacik
2020-11-10 15:01 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Josef Bacik @ 2020-11-09 18:02 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-block, nbd
On 11/9/20 12:30 PM, Christoph Hellwig wrote:
> bdget_disk needs to be paired with bdput to not leak a reference
> on the block device inode.
>
> Fixes: 08ba91ee6e2c ("nbd: Add the nbd NBD_DISCONNECT_ON_CLOSE config flag.")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nbd: fix a block_device refcount leak in nbd_release
2020-11-09 17:30 [PATCH] nbd: fix a block_device refcount leak in nbd_release Christoph Hellwig
2020-11-09 18:02 ` Josef Bacik
@ 2020-11-10 15:01 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2020-11-10 15:01 UTC (permalink / raw)
To: Christoph Hellwig, josef; +Cc: linux-block, nbd
On 11/9/20 10:30 AM, Christoph Hellwig wrote:
> bdget_disk needs to be paired with bdput to not leak a reference
> on the block device inode.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-10 15:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-09 17:30 [PATCH] nbd: fix a block_device refcount leak in nbd_release Christoph Hellwig
2020-11-09 18:02 ` Josef Bacik
2020-11-10 15:01 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox