Linux block layer
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Javier González" <javier@javigon.com>
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
	hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@kernel.dk,
	joshi.k@samsung.com, k.jensen@samsung.com, Niklas.Cassel@wdc.com,
	"Javier González" <javier.gonz@samsung.com>
Subject: Re: [PATCH V2] nvme: enable ro namespace for ZNS without append
Date: Tue, 10 Nov 2020 10:43:54 +0100	[thread overview]
Message-ID: <20201110094354.GB25672@lst.de> (raw)
In-Reply-To: <20201110093938.25386-1-javier.gonz@samsung.com>

> -	if (id->nsattr & NVME_NS_ATTR_RO)
> +	if (id->nsattr & NVME_NS_ATTR_RO ||
> +			test_bit(NVME_NS_FORCE_RO, &ns->flags))
>  		set_disk_ro(disk, true);
>  	else
>  		set_disk_ro(disk, false);

This has a very minor conflict with the patch from Sagi to remove the
else side of the clause.  I'll merge your patch and will fix unless
someone else objects to the approach.

Note that as discussed we really need a hard read-only settings
instead of set_disk_ro for both NVME_NS_ATTR_RO and the zns with missing
features case, but I'll look into that once I've got a few other things
off my plate.

  reply	other threads:[~2020-11-10  9:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10  9:39 [PATCH V2] nvme: enable ro namespace for ZNS without append Javier González
2020-11-10  9:43 ` Christoph Hellwig [this message]
2020-11-10 10:15   ` Javier González
2020-11-10 11:25   ` [PATCH V2] " Niklas Cassel
2020-11-10 19:55     ` Javier González
2020-11-10 14:16 ` [PATCH V2] " Keith Busch
2020-11-10 15:53   ` Javier González

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201110094354.GB25672@lst.de \
    --to=hch@lst.de \
    --cc=Niklas.Cassel@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=javier.gonz@samsung.com \
    --cc=javier@javigon.com \
    --cc=joshi.k@samsung.com \
    --cc=k.jensen@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox