Linux block layer
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Oleksii Kurochko <olkuroch@cisco.com>,
	linux-block@vger.kernel.org
Subject: Re: split hard read-only vs read-only policy
Date: Sat, 14 Nov 2020 10:18:25 +0100	[thread overview]
Message-ID: <20201114091825.GA18618@lst.de> (raw)
In-Reply-To: <4f8190a8-55a3-bc2d-540f-75e666810dd4@grimberg.me>

On Fri, Nov 13, 2020 at 11:51:38AM -0800, Sagi Grimberg wrote:
>
>> Hi Jens,
>>
>> this series resurrects a patch from Martin to properly split the flag
>> indicating a disk has been set read-only by the hardware vs the userspace
>> policy set through the BLKROSET ioctl.
>>
>
> Looks good,
>
> Doesn't this miss restoring the clear disk ro in nvme?

Yes, eventually.

      reply	other threads:[~2020-11-14  9:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13  8:46 split hard read-only vs read-only policy Christoph Hellwig
2020-11-13  8:47 ` [PATCH 1/3] block: Fix read-only block device setting after revalidate Christoph Hellwig
2020-11-16  3:55   ` Martin K. Petersen
2020-11-16 17:37     ` Christoph Hellwig
2020-11-13  8:47 ` [PATCH 2/3] rbd: remove the ->set_read_only methods Christoph Hellwig
2020-11-13  8:47 ` [PATCH 3/3] block: replace hd_struct.make_it_fail with a flag Christoph Hellwig
2020-11-13 18:44 ` split hard read-only vs read-only policy Martin K. Petersen
2020-11-13 19:51 ` Sagi Grimberg
2020-11-14  9:18   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201114091825.GA18618@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=olkuroch@cisco.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox