From: Dongjoo Seo <commisori28@gmail.com>
To: linux-block@vger.kernel.org
Subject: [PATCH] blk-mq: modify hybrid sleep time to aggressive
Date: Tue, 17 Nov 2020 01:43:22 +0900 [thread overview]
Message-ID: <20201116164322.GA7283@dongjoo-desktop> (raw)
Current sleep time for hybrid polling is half of mean time.
The 'half' sleep time is good for minimizing the cpu utilization.
But, the problem is that its cpu utilization is still high.
this patch can help to minimize the cpu utilization side.
Below 1,2 is my test hardware sets.
1. Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz + Samsung 970 pro 1Tb
2. Intel(R) Core(TM) i7-5820K CPU @ 3.30GHz + INTEL SSDPED1D480GA 480G
| Classic Polling | Hybrid Polling | this Patch
-----------------------------------------------------------------
cpu util | IOPS(k) | cpu util | IOPS | cpu util | IOPS |
-----------------------------------------------------------------
1. 99.96 | 491 | 56.98 | 467 | 35.98 | 442 |
-----------------------------------------------------------------
2. 99.94 | 582 | 56.3 | 582 | 35.28 | 582 |
cpu util means that sum of sys and user util.
I used 4k rand read for this test.
because that case is worst case of I/O performance side.
below one is my fio setup.
name=pollTest
ioengine=pvsync2
hipri
direct=1
size=100%
randrepeat=0
time_based
ramp_time=0
norandommap
refill_buffers
log_avg_msec=1000
log_max_value=1
group_reporting
filename=/dev/nvme0n1
[rd_rnd_qd_1_4k_1w]
bs=4k
iodepth=32
numjobs=[num of cpus]
rw=randread
runtime=60
write_bw_log=bw_rd_rnd_qd_1_4k_1w
write_iops_log=iops_rd_rnd_qd_1_4k_1w
write_lat_log=lat_rd_rnd_qd_1_4k_1w
Thanks
Signed-off-by: Dongjoo Seo <commisori28@gmail.com>
---
block/blk-mq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 1b25ec2fe9be..c3d578416899 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -3749,8 +3749,7 @@ static unsigned long blk_mq_poll_nsecs(struct request_queue *q,
return ret;
if (q->poll_stat[bucket].nr_samples)
- ret = (q->poll_stat[bucket].mean + 1) / 2;
-
+ ret = (q->poll_stat[bucket].mean + 1) * 3 / 4;
return ret;
}
--
2.17.1
next reply other threads:[~2020-11-16 16:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 16:43 Dongjoo Seo [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-18 0:47 [PATCH] blk-mq: modify hybrid sleep time to aggressive Dongjoo Seo
2020-11-18 7:07 ` Christoph Hellwig
2020-11-18 7:16 ` Damien Le Moal
2020-11-18 9:26 ` Pavel Begunkov
[not found] ` <7F6FFFCB-3FD1-4A7B-8D30-FF4BBAD4AEA4@gmail.com>
2020-11-18 14:17 ` Pavel Begunkov
[not found] ` <CABM9hu3FE6ZZL=oWznbJUw2i9i8qJ1AYKotg_uEeAe1Vu+8Ong@mail.gmail.com>
2020-11-19 17:51 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116164322.GA7283@dongjoo-desktop \
--to=commisori28@gmail.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox