linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yi Zhang <yi.zhang@redhat.com>
To: osandov@osandov.com, bvanassche@acm.org
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	sagi@grimberg.me
Subject: [PATCH V3 blktests 2/5] tests/nvmeof-mp/rc: run nvmeof-mp tests if we set multipath=N
Date: Thu, 26 Nov 2020 16:35:29 +0800	[thread overview]
Message-ID: <20201126083532.27509-3-yi.zhang@redhat.com> (raw)
In-Reply-To: <20201126083532.27509-1-yi.zhang@redhat.com>

To enable it, just do bellow step before we run it:
$ echo "options nvme_core multipath=N" >/etc/modprobe.d/nvme.conf

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
---
 tests/nvmeof-mp/rc | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/nvmeof-mp/rc b/tests/nvmeof-mp/rc
index d7a7c87..c77526f 100755
--- a/tests/nvmeof-mp/rc
+++ b/tests/nvmeof-mp/rc
@@ -16,9 +16,11 @@ group_requires() {
 
 	# Since the nvmeof-mp tests are based on the dm-mpath driver, these
 	# tests are incompatible with the NVME_MULTIPATH kernel configuration
-	# option.
-	if _have_kernel_option NVME_MULTIPATH; then
-		SKIP_REASON="CONFIG_NVME_MULTIPATH has been set in .config"
+	# option with multipathing enabled in the nvme_core kernel module.
+	if _have_kernel_option NVME_MULTIPATH && \
+		_have_module_param_value nvme_core multipath Y; then
+		SKIP_REASON="CONFIG_NVME_MULTIPATH has been set in .config \
+and multipathing has been enabled in the nvme_core kernel module"
 		return
 	fi
 
-- 
2.21.0


  parent reply	other threads:[~2020-11-26  8:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26  8:35 [PATCH V3 blktests 0/5] nvmeof-mp/srp/nvme-rdma misc fix and enhancement Yi Zhang
2020-11-26  8:35 ` [PATCH V3 blktests 1/5] tests/srp/rc: update the ib_srpt module name Yi Zhang
2020-11-26  8:35 ` Yi Zhang [this message]
2020-11-26  8:35 ` [PATCH V3 blktests 3/5] nvmeof-mp/012, srp/012: fix the scheduler list Yi Zhang
2020-11-26 16:29   ` Bart Van Assche
2020-11-26  8:35 ` [PATCH V3 blktests 4/5] common/rc: _have_iproute2 fix for "ip -V" change Yi Zhang
2020-11-26 16:30   ` Bart Van Assche
2020-11-26  8:35 ` [PATCH V3 blktests 5/5] common/multipath-over-rdma: allow to set use_siw Yi Zhang
2020-11-26 16:31   ` Bart Van Assche
2021-01-04 22:48 ` [PATCH V3 blktests 0/5] nvmeof-mp/srp/nvme-rdma misc fix and enhancement Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201126083532.27509-3-yi.zhang@redhat.com \
    --to=yi.zhang@redhat.com \
    --cc=bvanassche@acm.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=osandov@osandov.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).