From: Christoph Hellwig <hch@infradead.org>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 1/2] block: optimise for_each_bvec() advance
Date: Thu, 26 Nov 2020 10:00:59 +0000 [thread overview]
Message-ID: <20201126100059.GA949@infradead.org> (raw)
In-Reply-To: <8a399fe52e05c5aece4424b4ce114ec4e5b40b99.1606240077.git.asml.silence@gmail.com>
On Tue, Nov 24, 2020 at 05:58:12PM +0000, Pavel Begunkov wrote:
> Because of how for_each_bvec() works it never advances across multiple
> entries at a time, so bvec_iter_advance() is an overkill. Add
> specialised bvec_iter_advance_single() that is faster. It also handles
> zero-len bvecs, so can kill bvec_iter_skip_zero_bvec().
>
> text data bss dec hex filename
> before:
> 23977 805 0 24782 60ce lib/iov_iter.o
> before, bvec_iter_advance() w/o WARN_ONCE()
> 22886 600 0 23486 5bbe ./lib/iov_iter.o
> after:
> 21862 600 0 22462 57be lib/iov_iter.o
>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>
> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-11-26 10:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 17:58 [PATCH 0/2] optimise bvec/bio iteration Pavel Begunkov
2020-11-24 17:58 ` [PATCH 1/2] block: optimise for_each_bvec() advance Pavel Begunkov
2020-11-26 10:00 ` Christoph Hellwig [this message]
2020-11-24 17:58 ` [PATCH 2/2] bio: optimise bvec iteration Pavel Begunkov
2020-11-26 10:02 ` Christoph Hellwig
2020-11-26 12:32 ` Pavel Begunkov
2020-12-02 13:50 ` Pavel Begunkov
2020-12-02 14:56 ` Christoph Hellwig
2020-12-02 16:47 ` [PATCH 0/2] optimise bvec/bio iteration Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126100059.GA949@infradead.org \
--to=hch@infradead.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).