Re: [PATCH 24/45] block: remove i_bdev

Hannes Reinecke
2020-11-30T07:32:39Z

On 11/28/20 5:14 PM, Christoph Hellwig wrote:
> Switch the block device lookup interfaces to directly work with a dev_t
> so that struct block_device references are only acquired by the
> blkdev_get variants (and the blk-cgroup special case). This means that
> we now don't need an extra reference in the inode and can generally
> simplify handling of struct block_device to keep the lookups contained
> in the core block layer code.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Acked-by: Tejun Heo <tj@kernel.org>
> Acked-by: Coly Li <colyli@suse.de> [bcache]
> ---
> block/ioctl.c | 3 +-
> drivers/block/loop.c | 8 +-
> drivers/md/bcache/super.c | 20 +-
> drivers/md/dm-table.c | 9 +-
> drivers/mtd/mtdsuper.c | 17 +-
> drivers/target/target_core_file.c | 6 +-
> drivers/usb/gadget/function/storage_common.c | 8 +-
> fs/block_dev.c | 196 +++++--------------
> fs/btrfs/volumes.c | 13 +-
> fs/inode.c | 3 -
> fs/internal.h | 7 +-
> fs/io_uring.c | 10 +-
> fs/pipe.c | 5 +-
> fs/quota/quota.c | 19 +-
> fs/statfs.c | 2 +-
> fs/super.c | 44 ++---
> include/linux/blkdev.h | 2 +-
> include/linux/fs.h | 1 -
> 18 files changed, 121 insertions(+), 252 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer