Re: [PATCH 44/45] block: merge struct block_device and struct hd_struct

Hannes Reinecke
2020-11-30T07:52:09Z

On 11/28/20 5:15 PM, Christoph Hellwig wrote:
> Instead of having two structures that represent each block device with
> different life time rules, merge them into a single one. This also
> greatly simplifies the reference counting rules, as we can use the inode
> reference count as the main reference count for the new struct
> block_device, with the device model reference front ending it for device
> model interaction.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> block/blk-cgroup.c | 9 ++-
> block/blk.h | 2 +-
> block/genhd.c | 89 +++++++++--------------------
> block/partitions/core.c | 116 +++++++++++++++-----------------------
> fs/block_dev.c | 9 ---
> include/linux/blk_types.h | 8 ++-
> include/linux/blkdev.h | 1 -
> include/linux/genhd.h | 40 +++----------
> init/do_mounts.c | 21 ++++---
> kernel/trace/blktrace.c | 43 +++-----------
> 10 files changed, 108 insertions(+), 230 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer