From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F12C64E7B for ; Mon, 30 Nov 2020 02:38:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 501F82076C for ; Mon, 30 Nov 2020 02:38:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VEVZk0gx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726085AbgK3Ch5 (ORCPT ); Sun, 29 Nov 2020 21:37:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:27946 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbgK3Ch5 (ORCPT ); Sun, 29 Nov 2020 21:37:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606703790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jW+RayTBSmH3fVJpGSZDzWDe9t91mxwu+8Qnq1c5Lb4=; b=VEVZk0gxfyMru1lp0gNcu8uUAkYVq6U9RgIynkVJUxcUUvncn8N0zHoiJZDK+xXFYOie0n 7Jn/8kh/LXupFTYTUNWAyK64AAa4RDZ/M/Ig4TDtxxFjA7IAR/AmUNINkqitjHxArQzFKr RGGHtWoc3NplvBrzhYQ09QHY7c0ifgo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-344-KylBdkFBMcK6HGqWjUsGHA-1; Sun, 29 Nov 2020 21:36:25 -0500 X-MC-Unique: KylBdkFBMcK6HGqWjUsGHA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2A9AC1087D68; Mon, 30 Nov 2020 02:36:23 +0000 (UTC) Received: from T590 (ovpn-12-190.pek2.redhat.com [10.72.12.190]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 10EB660843; Mon, 30 Nov 2020 02:36:10 +0000 (UTC) Date: Mon, 30 Nov 2020 10:36:06 +0800 From: Ming Lei To: Jens Axboe , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, Christoph Hellwig Cc: Qian Cai , Sumit Saxena , John Garry , Kashyap Desai , Bart Van Assche , Hannes Reinecke Subject: Re: [PATCH 0/3] blk-mq/nvme-loop: use nvme-loop's lock class for addressing lockdep false positive warning Message-ID: <20201130023606.GC230145@T590> References: <20201112075526.947079-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112075526.947079-1-ming.lei@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Nov 12, 2020 at 03:55:23PM +0800, Ming Lei wrote: > Hi, > > Qian reported there is hang during booting when shared host tagset is > introduced on megaraid sas. Sumit reported the whole SCSI probe takes > about ~45min in his test. > > Turns out it is caused by nr_hw_queues increased, especially commit > b3c6a5997541("block: Fix a lockdep complaint triggered by request queue flushing") > adds synchronize_rcu() for each hctx's release handler. > > Address the original lockdep false positive warning by simpler way, then > long scsi probe can be avoided with lockdep enabled. > > Ming Lei (3): > blk-mq: add new API of blk_mq_hctx_set_fq_lock_class > nvme-loop: use blk_mq_hctx_set_fq_lock_class to set loop's lock class > Revert "block: Fix a lockdep complaint triggered by request queue > flushing" > > block/blk-flush.c | 30 +++++++++++++++++++++++++----- > block/blk.h | 1 - > drivers/nvme/target/loop.c | 10 ++++++++++ > include/linux/blk-mq.h | 3 +++ > 4 files changed, 38 insertions(+), 6 deletions(-) > > Cc: Qian Cai > Cc: Sumit Saxena > Cc: John Garry > Cc: Kashyap Desai > Cc: Bart Van Assche > Cc: Hannes Reinecke Hello Jens, Any chance to take a look? And this issue has been reported several times in RH internal test. Thanks, Ming