Re: [PATCH 07/45] loop: do not call set_blocksize

Hannes Reinecke
2020-11-30T07:08:53Z

On 11/28/20 5:14 PM, Christoph Hellwig wrote:
> set_blocksize is used by file systems to use their preferred buffer cache
> block size. Block drivers should not set it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Jan Kara <jack@suse.cz>
> ---
> drivers/block/loop.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 9a27d4f1c08aac..b42c728620c9e4 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1164,9 +1164,6 @@ static int loop_configure(struct loop_device *lo, fmode_t mode,
> size = get_loop_size(lo, file);
> loop_set_size(lo, size);
>
> - set_blocksize(bdev, S_ISBLK(inode->i_mode) ?
> - block_size(inode->i_bdev) : PAGE_SIZE);
> -
> lo->lo_state = Lo_bound;
> if (part_shift)
> lo->lo_flags |= LO_FLAGS_PARTSCAN;
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer