From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Keith Busch <kbusch@kernel.org>
Cc: "Javier González" <javier@javigon.com>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
hch@lst.de, sagi@grimberg.me
Subject: Re: [PATCH 4/4] nvme: enable char device per namespace
Date: Wed, 2 Dec 2020 12:00:43 +0900 [thread overview]
Message-ID: <20201202030043.GA21178@localhost.localdomain> (raw)
In-Reply-To: <20201201193002.GB27728@redsun51.ssa.fujisawa.hgst.com>
On 20-12-02 04:30:02, Keith Busch wrote:
> On Tue, Dec 01, 2020 at 07:57:32PM +0100, Javier González wrote:
> > On 01.12.2020 23:03, Minwoo Im wrote:
> > > > +
> > > > + device_initialize(&ns->cdev_device);
> > > > + ns->cdev_device.devt = MKDEV(MAJOR(nvme_ns_base_chr_devt),
> > > > + ns->head->instance);
> > > > + ns->cdev_device.class = nvme_ns_class;
> > > > + ns->cdev_device.parent = ctrl->device;
> > > > + ns->cdev_device.groups = nvme_ns_char_id_attr_groups;
> > > > + dev_set_drvdata(&ns->cdev_device, ns);
> > > > +
> > > > + sprintf(cdisk_name, "nvme%dc%dn%d", ctrl->subsys->instance,
> > > > + ctrl->instance, ns->head->instance);
> > >
> > > In multi-path, private namespaces for a head are not in /dev, so I don't
> > > think this will hurt private namespaces (e.g., nvme0c0n1), But it looks
> > > like it will make a little bit confusions between chardev and hidden blkdev.
> > >
> > > I don't against to update nvme-cli things also even naming conventions are
> > > going to become different than nvmeXcYnZ.
> >
> > Agree. But as I understand it, Keith had a good argument to keep names
> > aligned with the hidden bdev.
>
> My suggested naming makes it as obvious as possible that the character
> device in /dev/ and the hidden block device in /sys/ are referring to
> the same thing. What is confusing about that?
I meant that someone might misunderstand tht /dev/nvmeXcYnZ is also a
blkdev just like /dev/nvmeXnY. I'm just saying it might be, but I'm
fine with suggested naming as those two are indicating a single
concept (namespace).
next prev parent reply other threads:[~2020-12-02 3:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 12:56 [PATCH 0/4] nvme: enable per-namespace char device javier
2020-12-01 12:56 ` [PATCH 1/4] nvme: remove unnecessary return values javier
2020-12-01 14:04 ` Minwoo Im
2020-12-01 12:56 ` [PATCH 2/4] nvme: rename controller base dev_t char device javier
2020-12-01 14:05 ` Minwoo Im
2020-12-01 12:56 ` [PATCH 3/4] nvme: rename bdev operations javier
2020-12-01 14:06 ` Minwoo Im
2020-12-01 12:56 ` [PATCH 4/4] nvme: enable char device per namespace javier
2020-12-01 14:03 ` Minwoo Im
2020-12-01 18:57 ` Javier González
2020-12-01 19:30 ` Keith Busch
2020-12-01 19:38 ` Christoph Hellwig
2020-12-01 20:44 ` Javier González
2020-12-07 14:06 ` Christoph Hellwig
2020-12-02 3:00 ` Minwoo Im [this message]
2020-12-01 19:35 ` [PATCH 0/4] nvme: enable per-namespace char device Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202030043.GA21178@localhost.localdomain \
--to=minwoo.im.dev@gmail.com \
--cc=hch@lst.de \
--cc=javier@javigon.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox