From: Christoph Hellwig <hch@infradead.org>
To: Jeffle Xu <jefflexu@linux.alibaba.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
joseph.qi@linux.alibaba.com
Subject: Re: [PATCH] block: fix inflight statistics of part0
Date: Wed, 2 Dec 2020 08:29:41 +0000 [thread overview]
Message-ID: <20201202082941.GA23319@infradead.org> (raw)
In-Reply-To: <20201126094833.61309-1-jefflexu@linux.alibaba.com>
On Thu, Nov 26, 2020 at 05:48:33PM +0800, Jeffle Xu wrote:
> The inflight of partition 0 doesn't include inflight IOs to all
> sub-partitions, since currently mq calculates inflight of specific
> partition by simply camparing the value of the partition pointer.
>
> Thus the following case is possible:
>
> $ cat /sys/block/vda/inflight
> ?? ?? ?? ??0 ?? ?? ?? ??0
> $ cat /sys/block/vda/vda1/inflight
> ?? ?? ?? ??0 ?? ?? ??128
>
> Partition 0 should be specially handled since it represents the whole
> disk.
>
> Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But can you resend with your information on the old kernels, and maybe
even with a Fixes tag?
next prev parent reply other threads:[~2020-12-02 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 9:48 [PATCH] block: fix inflight statistics of part0 Jeffle Xu
2020-11-30 6:46 ` JeffleXu
2020-11-30 17:05 ` Christoph Hellwig
2020-12-01 1:53 ` JeffleXu
2020-12-02 8:29 ` Christoph Hellwig [this message]
2020-12-02 8:49 ` JeffleXu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202082941.GA23319@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=jefflexu@linux.alibaba.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).