Re: [PATCH] block/rnbd-clt: Fix error code in rnbd_clt_add_dev_symlink()

[Dan Carpenter <dan.carpenter@oracle.com>]

On Wed, Dec 09, 2020 at 08:36:31AM +0100, Jinpu Wang wrote:
> Hi Dan,
> 
> 
> 
> On Wed, Dec 9, 2020 at 7:52 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > The "ret" variable should be set to -ENOMEM but it returns uninitialized
> > stack data.
> >
> > Fixes: 64e8a6ece1a5 ("block/rnbd-clt: Dynamically alloc buffer for pathname & blk_symlink_name")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Thanks for the patch. But there is already a fix from Colin merged in
> block tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-5.11/drivers&id=733c15bd3a944b8eeaacdddf061759b6a83dd3f4
> 
> There is still other problem through with commit 64e8a6ece1a5
> ("block/rnbd-clt: Dynamically alloc buffer for pathname &
> blk_symlink_name")
> 
> I will send the fix today together with other changes.

Ah...  Haha...  Sorry about that.  We already discussed this yesterday.

What happens is that when I write a patch, I normally save it in my
postponed messages until the next day.  But then I decided to not fix it
but instead to just report it.  Unfortunately, I forgot to delete it and
I also forgot about yesterday's discussion because I have the memory of
a gnat.  :P

regards,
dan carpenter