public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V3 3/6] block: don't allocate inline bvecs if this bioset needn't bvecs
Date: Mon, 11 Jan 2021 11:05:54 +0800	[thread overview]
Message-ID: <20210111030557.4154161-4-ming.lei@redhat.com> (raw)
In-Reply-To: <20210111030557.4154161-1-ming.lei@redhat.com>

The inline bvecs won't be used if user needn't bvecs by not passing
BIOSET_NEED_BVECS, so don't allocate bvecs in this situation.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
 block/bio.c         | 7 +++++--
 include/linux/bio.h | 1 +
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/block/bio.c b/block/bio.c
index cfa0e9db30e0..496aa5938f79 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -89,8 +89,7 @@ static struct bio_slab *create_bio_slab(unsigned int size)
 
 static inline unsigned int bs_bio_slab_size(struct bio_set *bs)
 {
-	return bs->front_pad + sizeof(struct bio) +
-		BIO_INLINE_VECS * sizeof(struct bio_vec);
+	return bs->front_pad + sizeof(struct bio) + bs->back_pad;
 }
 
 static struct kmem_cache *bio_find_or_create_slab(struct bio_set *bs)
@@ -1572,6 +1571,10 @@ int bioset_init(struct bio_set *bs,
 		int flags)
 {
 	bs->front_pad = front_pad;
+	if (flags & BIOSET_NEED_BVECS)
+		bs->back_pad = BIO_INLINE_VECS * sizeof(struct bio_vec);
+	else
+		bs->back_pad = 0;
 
 	spin_lock_init(&bs->rescue_lock);
 	bio_list_init(&bs->rescue_list);
diff --git a/include/linux/bio.h b/include/linux/bio.h
index 1edda614f7ce..f606eb1e556f 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -703,6 +703,7 @@ struct bio_set {
 	mempool_t bvec_integrity_pool;
 #endif
 
+	unsigned int back_pad;
 	/*
 	 * Deadlock avoidance for stacking block drivers: see comments in
 	 * bio_alloc_bioset() for details
-- 
2.28.0


  parent reply	other threads:[~2021-01-11  3:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11  3:05 [PATCH V3 0/6] block: improvement on bioset & bvec allocation Ming Lei
2021-01-11  3:05 ` [PATCH V3 1/6] block: manage bio slab cache by xarray Ming Lei
2021-01-11  4:39   ` Pavel Begunkov
2021-01-11  6:57   ` Hannes Reinecke
2021-01-11  3:05 ` [PATCH V3 2/6] block: don't pass BIOSET_NEED_BVECS for q->bio_split Ming Lei
2021-01-11  4:41   ` Pavel Begunkov
2021-01-11  6:57   ` Hannes Reinecke
2021-01-11  3:05 ` Ming Lei [this message]
2021-01-11  4:41   ` [PATCH V3 3/6] block: don't allocate inline bvecs if this bioset needn't bvecs Pavel Begunkov
2021-01-11  6:58   ` Hannes Reinecke
2021-01-11  3:05 ` [PATCH V3 4/6] block: set .bi_max_vecs as actual allocated vector number Ming Lei
2021-01-11  4:42   ` Pavel Begunkov
2021-01-11  6:59   ` Hannes Reinecke
2021-01-11  3:05 ` [PATCH V3 5/6] block: move three bvec helpers declaration into private helper Ming Lei
2021-01-11  4:42   ` Pavel Begunkov
2021-01-11  7:00   ` Hannes Reinecke
2021-01-11  3:05 ` [PATCH V3 6/6] bcache: don't pass BIOSET_NEED_BVECS for the 'bio_set' embedded in 'cache_set' Ming Lei
2021-01-11  3:54   ` Coly Li
2021-01-11  7:00   ` Hannes Reinecke
2021-01-11  4:35 ` [PATCH V3 0/6] block: improvement on bioset & bvec allocation Pavel Begunkov
2021-01-25  2:27 ` Ming Lei
2021-01-25  4:24 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210111030557.4154161-4-ming.lei@redhat.com \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox