linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	hch@lst.de, sagi@grimberg.me, damien.lemoal@wdc.com
Subject: Re: [PATCH V9 5/9] nvmet: add bio get helper for different backends
Date: Tue, 12 Jan 2021 08:33:15 +0100	[thread overview]
Message-ID: <20210112073315.GA24288@lst.de> (raw)
In-Reply-To: <20210112042623.6316-6-chaitanya.kulkarni@wdc.com>

I'm not a huge fan of this helper, especially as it sets an end_io
callback only for the allocated case, which is a weird calling
convention.

  parent reply	other threads:[~2021-01-12  7:34 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12  4:26 [PATCH V9 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
2021-01-12  4:26 ` [PATCH V9 1/9] block: export bio_add_hw_pages() Chaitanya Kulkarni
2021-01-12  5:40   ` Damien Le Moal
2021-01-12  7:24   ` Christoph Hellwig
2021-01-13  1:20     ` Chaitanya Kulkarni
2021-01-12  4:26 ` [PATCH V9 2/9] nvmet: add lba to sect conversion helpers Chaitanya Kulkarni
2021-01-12  5:08   ` Damien Le Moal
2021-01-18 18:19   ` Christoph Hellwig
2021-01-12  4:26 ` [PATCH V9 3/9] nvmet: add NVM command set identifier support Chaitanya Kulkarni
2021-01-12  7:27   ` Christoph Hellwig
2021-01-13  4:16     ` Chaitanya Kulkarni
2021-01-18 18:21       ` Christoph Hellwig
2021-01-12  4:26 ` [PATCH V9 4/9] nvmet: add ZBD over ZNS backend support Chaitanya Kulkarni
2021-01-12  5:32   ` Damien Le Moal
2021-01-12  6:11     ` Chaitanya Kulkarni
2021-01-12  6:31       ` Damien Le Moal
2021-01-12  7:48   ` Christoph Hellwig
2021-01-12  7:52     ` Damien Le Moal
2021-01-18 18:25       ` Christoph Hellwig
2021-01-19  0:02         ` Damien Le Moal
2021-01-19  4:28         ` Damien Le Moal
2021-01-19  6:15           ` hch
2021-01-13  4:57     ` Chaitanya Kulkarni
2021-01-18 18:27       ` Christoph Hellwig
2021-01-12  4:26 ` [PATCH V9 5/9] nvmet: add bio get helper for different backends Chaitanya Kulkarni
2021-01-12  5:37   ` Damien Le Moal
2021-01-12  5:55     ` Chaitanya Kulkarni
2021-01-12  7:33   ` Christoph Hellwig [this message]
2021-01-13  5:03     ` Chaitanya Kulkarni
2021-01-18 18:28       ` Christoph Hellwig
2021-01-19  4:57         ` Chaitanya Kulkarni
2021-01-12  4:26 ` [PATCH V9 6/9] nvmet: add bio init " Chaitanya Kulkarni
2021-01-12  5:40   ` Damien Le Moal
2021-01-12  5:57     ` Chaitanya Kulkarni
2021-01-12  6:27       ` Damien Le Moal
2021-01-12  7:33   ` Christoph Hellwig
2021-01-13  5:04     ` Chaitanya Kulkarni
2021-01-18 18:33       ` Christoph Hellwig
2021-01-12  4:26 ` [PATCH V9 7/9] nvmet: add bio put " Chaitanya Kulkarni
2021-01-12  4:26 ` [PATCH V9 8/9] nvmet: add common I/O length check helper Chaitanya Kulkarni
2021-01-12  7:35   ` Christoph Hellwig
2021-01-13  5:07     ` Chaitanya Kulkarni
2021-01-18 18:34       ` Christoph Hellwig
2021-01-12  4:26 ` [PATCH V9 9/9] nvmet: call nvmet_bio_done() for zone append Chaitanya Kulkarni
2021-01-12  7:36   ` Christoph Hellwig
2021-01-13  5:13     ` Chaitanya Kulkarni
2021-01-12  6:12 ` [PATCH V9 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
2021-02-10 22:42 ` Chaitanya Kulkarni
2021-02-11  7:20   ` hch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210112073315.GA24288@lst.de \
    --to=hch@lst.de \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=damien.lemoal@wdc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).