From: Minwoo Im <minwoo.im.dev@gmail.com>
To: "Javier González" <javier@javigon.com>
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
hch@lst.de, kbusch@kernel.org, sagi@grimberg.me
Subject: Re: nvme: enable char device per namespace
Date: Tue, 12 Jan 2021 20:26:18 +0900 [thread overview]
Message-ID: <20210112112618.GA25093@localhost.localdomain> (raw)
In-Reply-To: <20210112092207.GA4888@localhost.localdomain>
On 21-01-12 18:22:07, Minwoo Im wrote:
> Hello Javier,
>
> I tested this patch based on nvme-5.11:
>
> [ 1.219747] BUG: unable to handle page fault for address: 0000000100000041
> [ 1.220518] #PF: supervisor read access in kernel mode
> [ 1.220582] #PF: error_code(0x0000) - not-present page
> [ 1.220582] PGD 0 P4D 0
> [ 1.220582] Oops: 0000 [#1] SMP PTI
> [ 1.220582] CPU: 0 PID: 7 Comm: kworker/u16:0 Not tainted 5.11.0-rc1+ #46
> [ 1.220582] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014
> [ 1.220582] Workqueue: nvme-wq nvme_scan_work
> [ 1.220582] RIP: 0010:nvme_ns_id_attrs_are_visible+0x10f/0x152
> [ 1.220582] Code: 81 7d d0 80 f9 a1 82 74 0a 48 81 7d d0 a0 f9 a1 82 75 50 48 8b 45 e8 48 89 45 f8 48 8b 45 f8 48 83 e8 60 48 8b 80 60 03 00 00 <48> 8b 40 40 48 3d e0 d1 4d 82 74 07 b8 00 00 00 00 eb 2e 48 8b 45
> [ 1.220582] RSP: 0000:ffffc90000047b70 EFLAGS: 00010282
> [ 1.220582] RAX: 0000000100000001 RBX: ffffffff824ddb20 RCX: 0000000000000124
> [ 1.220582] RDX: ffff8881026eac00 RSI: ffffffff82a1f980 RDI: ffff888102745058
> [ 1.220582] RBP: ffffc90000047ba8 R08: ffff888102948718 R09: 0000000000000000
> [ 1.220582] R10: 0000000000000000 R11: ffff888100465080 R12: ffff888102745058
> [ 1.220582] R13: ffff888102948600 R14: 0000000000000000 R15: ffffffff82a1f548
> [ 1.220582] FS: 0000000000000000(0000) GS:ffff88842fc00000(0000) knlGS:0000000000000000
> [ 1.220582] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 1.220582] CR2: 0000000100000041 CR3: 000000000280c001 CR4: 0000000000370ef0
> [ 1.220582] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [ 1.220582] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> [ 1.220582] Call Trace:
> [ 1.220582] internal_create_group+0xde/0x390
> [ 1.220582] internal_create_groups.part.4+0x3e/0xa0
> [ 1.220582] device_add+0x3cf/0x830
> [ 1.220582] ? cdev_get+0x20/0x20
> [ 1.220582] ? cdev_purge+0x60/0x60
> [ 1.220582] cdev_device_add+0x44/0x70
> [ 1.220582] ? cdev_init+0x50/0x60
> [ 1.220582] nvme_alloc_chardev_ns+0x187/0x1eb
> [ 1.220582] nvme_alloc_ns+0x367/0x460
> [ 1.220582] nvme_validate_or_alloc_ns+0xe2/0x139
> [ 1.220582] nvme_scan_ns_list+0x113/0x17a
> [ 1.220582] nvme_scan_work+0xa5/0x106
> [ 1.220582] process_one_work+0x1dd/0x3e0
> [ 1.220582] worker_thread+0x2d/0x3b0
> [ 1.220582] ? cancel_delayed_work+0x90/0x90
> [ 1.220582] kthread+0x117/0x130
> [ 1.220582] ? kthread_park+0x90/0x90
> [ 1.220582] ret_from_fork+0x22/0x30
> [ 1.220582] Modules linked in:
> [ 1.220582] CR2: 0000000100000041
> [ 1.220582] ---[ end trace b1f509a1bbfbc113 ]---
> [ 1.220582] RIP: 0010:nvme_ns_id_attrs_are_visible+0x10f/0x152
> [ 1.220582] Code: 81 7d d0 80 f9 a1 82 74 0a 48 81 7d d0 a0 f9 a1 82 75 50 48 8b 45 e8 48 89 45 f8 48 8b 45 f8 48 83 e8 60 48 8b 80 60 03 00 00 <48> 8b 40 40 48 3d e0 d1 4d 82 74 07 b8 00 00 00 00 eb 2e 48 8b 45
> [ 1.220582] RSP: 0000:ffffc90000047b70 EFLAGS: 00010282
> [ 1.220582] RAX: 0000000100000001 RBX: ffffffff824ddb20 RCX: 0000000000000124
> [ 1.220582] RDX: ffff8881026eac00 RSI: ffffffff82a1f980 RDI: ffff888102745058
> [ 1.220582] RBP: ffffc90000047ba8 R08: ffff888102948718 R09: 0000000000000000
> [ 1.220582] R10: 0000000000000000 R11: ffff888100465080 R12: ffff888102745058
> [ 1.220582] R13: ffff888102948600 R14: 0000000000000000 R15: ffffffff82a1f548
> [ 1.220582] FS: 0000000000000000(0000) GS:ffff88842fc00000(0000) knlGS:0000000000000000
> [ 1.220582] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 1.220582] CR2: 0000000100000041 CR3: 000000000280c001 CR4: 0000000000370ef0
> [ 1.220582] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [ 1.220582] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
>
> And this happens when CONFIG_NVME_MULTIPATH=y configured. Please refere
> attached log up there :)
>
> Thanks!
If this chardev has to have ns_id_attr_group, we need to consider
nvme_ns_id_attrs_are_visible() to take care of dev_to_disk(dev) in case
non-block device.
Thanks!
next prev parent reply other threads:[~2021-01-12 11:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201216181838eucas1p15c687e5d1319d3fa581990e6cca73295@eucas1p1.samsung.com>
2020-12-16 18:18 ` [PATCH V4] nvme: enable char device per namespace javier
2021-01-11 18:53 ` Javier González
2021-01-12 9:22 ` Minwoo Im
2021-01-12 11:26 ` Minwoo Im [this message]
2021-01-12 18:30 ` Javier González
2021-01-12 18:33 ` Christoph Hellwig
2021-01-12 18:41 ` Javier González
2020-12-15 22:46 [PATCH V3] " Keith Busch
2020-12-16 8:01 ` Javier González
2020-12-16 16:26 ` Keith Busch
2020-12-16 17:43 ` Javier González
2020-12-16 17:53 ` Keith Busch
2020-12-17 13:29 ` Javier González
-- strict thread matches above, loose matches on Subject: below --
2020-12-08 13:29 [PATCH V2] " javier
2020-12-08 14:21 ` Christoph Hellwig
2020-12-09 9:16 ` Javier González
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112112618.GA25093@localhost.localdomain \
--to=minwoo.im.dev@gmail.com \
--cc=hch@lst.de \
--cc=javier@javigon.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox