From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@wdc.com>
Subject: Re: [PATCH v3 1/3] block: introduce zone_write_granularity limit
Date: Fri, 22 Jan 2021 09:42:09 +0100 [thread overview]
Message-ID: <20210122084209.GA15710@lst.de> (raw)
In-Reply-To: <20210122080014.174391-2-damien.lemoal@wdc.com>
> @@ -864,18 +891,20 @@ void blk_queue_set_zoned(struct gendisk *disk, enum blk_zoned_model model)
> * partitions and zoned block device support is enabled, else
> * we do nothing special as far as the block layer is concerned.
> */
> - if (!IS_ENABLED(CONFIG_BLK_DEV_ZONED) ||
> - disk_has_partitions(disk))
> - model = BLK_ZONED_NONE;
> - break;
> + if (IS_ENABLED(CONFIG_BLK_DEV_ZONED) &&
> + !disk_has_partitions(disk))
> + break;
> + model = BLK_ZONED_NONE;
> + fallthrough;
> case BLK_ZONED_NONE:
> default:
> if (WARN_ON_ONCE(model != BLK_ZONED_NONE))
> model = BLK_ZONED_NONE;
> + q->limits.zone_write_granularity = 0;
> break;
> }
>
> - disk->queue->limits.zoned = model;
> + q->limits.zoned = model;
> }
This looks a little strange. If we special case zoned vs not zoned
here anyway, why not set the zone_write_granularity to the logical
block size here by default.
next prev parent reply other threads:[~2021-01-22 8:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 8:00 [PATCH v3 0/3] block: add zone write granularity limit Damien Le Moal
2021-01-22 8:00 ` [PATCH v3 1/3] block: introduce zone_write_granularity limit Damien Le Moal
2021-01-22 8:42 ` Christoph Hellwig [this message]
2021-01-22 8:56 ` Damien Le Moal
2021-01-24 10:07 ` Christoph Hellwig
2021-01-25 5:32 ` Damien Le Moal
2021-01-25 5:34 ` Damien Le Moal
2021-01-23 2:43 ` Martin K. Petersen
2021-01-22 8:00 ` [PATCH v3 2/3] block: document zone_append_max_bytes attribute Damien Le Moal
2021-01-23 2:43 ` Martin K. Petersen
2021-01-23 3:03 ` Chaitanya Kulkarni
2021-01-22 8:00 ` [PATCH v3 3/3] zonefs: use zone write granularity as block size Damien Le Moal
2021-01-22 8:42 ` Christoph Hellwig
2021-01-23 2:44 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122084209.GA15710@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=keith.busch@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox