From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
David Anderson <dvander@google.com>,
Alistair Delva <adelva@google.com>, Todd Kjos <tkjos@google.com>,
Amit Pundir <amit.pundir@linaro.org>,
YongQin Liu <yongqin.liu@linaro.org>,
lkml <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [REGRESSION] "split bio_kmalloc from bio_alloc_bioset" causing crash shortly after bootup
Date: Tue, 23 Feb 2021 16:08:52 +0100 [thread overview]
Message-ID: <20210223150852.GA17662@lst.de> (raw)
In-Reply-To: <BYAPR04MB496574519941459FE83C437D86809@BYAPR04MB4965.namprd04.prod.outlook.com>
On Tue, Feb 23, 2021 at 07:37:52AM +0000, Chaitanya Kulkarni wrote:
> On 2/22/21 23:10, Christoph Hellwig wrote:
> > On Tue, Feb 23, 2021 at 03:51:23AM +0000, Chaitanya Kulkarni wrote:
> >> Looking at the other call sites do we need something like following ?
> >> Since __blk_queue_bounce() passes the NULL for the passthru case as a
> >> bio_set value ?
> > Well, that is a somewhat odd calling convention. What about the patch below
> > instead? That being we really need to kill this bouncing code off..
> I assume you are sending this patch, let me know otherwise.
> If you do please add, looks good.
I'll split the gfp_mask cleanup out, and will submit it with your as
the author if that is ok. I'll need a signoff, though.
next prev parent reply other threads:[~2021-02-23 15:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 3:06 [REGRESSION] "split bio_kmalloc from bio_alloc_bioset" causing crash shortly after bootup John Stultz
2021-02-23 3:39 ` Chaitanya Kulkarni
2021-02-23 4:22 ` John Stultz
2021-02-23 4:58 ` Chaitanya Kulkarni
2021-02-23 7:11 ` Christoph Hellwig
2021-02-23 3:51 ` Chaitanya Kulkarni
2021-02-23 7:10 ` Christoph Hellwig
2021-02-23 7:21 ` Chaitanya Kulkarni
2021-02-23 7:37 ` Chaitanya Kulkarni
2021-02-23 15:08 ` Christoph Hellwig [this message]
2021-02-23 15:12 ` Christoph Hellwig
2021-02-23 20:53 ` Chaitanya Kulkarni
2021-02-23 7:04 ` Christoph Hellwig
2021-02-23 7:22 ` Christoph Hellwig
2021-02-23 22:46 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223150852.GA17662@lst.de \
--to=hch@lst.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=adelva@google.com \
--cc=amit.pundir@linaro.org \
--cc=axboe@kernel.dk \
--cc=dvander@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tkjos@google.com \
--cc=yongqin.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox