From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
Tom Seewald <tseewald@gmail.com>
Subject: Re: [PATCH] block: reopen the device in blkdev_reread_part
Date: Wed, 24 Feb 2021 17:32:46 +0900 [thread overview]
Message-ID: <20210224083246.GB2166@localhost.localdomain> (raw)
In-Reply-To: <20210224072603.GA32368@lst.de>
On 21-02-24 08:26:03, Christoph Hellwig wrote:
> On Wed, Feb 24, 2021 at 10:52:02AM +0900, Minwoo Im wrote:
> > On 21-02-23 16:18:22, Christoph Hellwig wrote:
> > > Historically the BLKRRPART ioctls called into the now defunct ->revalidate
> > > method, which caused the sd driver to check if any media is present.
> > > When the ->revalidate method was removed this revalidation was lost,
> > > leading to lots of I/O errors when using the eject command. Fix this by
> > > reopening the device to rescan the partitions, and thus calling the
> > > revalidation logic in the sd driver.
> >
> > It looks like a related issue that I've reported in [1]. And this looks
> > much better!
>
> I don't think it fixes the block size issue, does it?
Uh... Sorry for the noise. This reopen is not the first shot so that the
block size will not be updated because bd_openers is not 0.
set_init_blocksize is not being invoked.
Sorry please ignore this noise.
next prev parent reply other threads:[~2021-02-24 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 15:18 [PATCH] block: reopen the device in blkdev_reread_part Christoph Hellwig
2021-02-24 1:38 ` Ming Lei
2021-02-24 1:52 ` Minwoo Im
2021-02-24 7:26 ` Christoph Hellwig
2021-02-24 8:32 ` Minwoo Im [this message]
2021-02-24 9:34 ` Minwoo Im
2021-02-24 2:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224083246.GB2166@localhost.localdomain \
--to=minwoo.im.dev@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=tseewald@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox