From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69C89C433DB for ; Mon, 1 Mar 2021 16:22:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24C2B64EE0 for ; Mon, 1 Mar 2021 16:22:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236663AbhCAQWB (ORCPT ); Mon, 1 Mar 2021 11:22:01 -0500 Received: from mx2.suse.de ([195.135.220.15]:50288 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237796AbhCAQUs (ORCPT ); Mon, 1 Mar 2021 11:20:48 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4FFD3AE14; Mon, 1 Mar 2021 16:20:00 +0000 (UTC) Date: Mon, 1 Mar 2021 17:19:59 +0100 From: Jean Delvare To: Jens Axboe Cc: linux-block@vger.kernel.org, Ming Lei , Omar Sandoval , Hannes Reinecke Subject: Re: [PATCH] block: Drop leftover references to RQF_SORTED Message-ID: <20210301171959.1ee26ef9@endymion> In-Reply-To: <7602f62a-f495-4c6e-3c95-d435a016b996@kernel.dk> References: <20210301120439.1fd0eb7b@endymion> <7602f62a-f495-4c6e-3c95-d435a016b996@kernel.dk> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi Jens, On Mon, 1 Mar 2021 08:13:18 -0700, Jens Axboe wrote: > On 3/1/21 4:04 AM, Jean Delvare wrote: > > Commit a1ce35fa49852db60fc6e268038530be533c5b15 ("block: remove dead > > elevator code") removed all users of RQF_SORTED. However it is still > > defined, and there is one reference left to it (which in effect is > > dead code). Clear it all up. > > > > Signed-off-by: Jean Delvare > > Cc: Jens Axboe > > Cc: Ming Lei > > Cc: Omar Sandoval > > Cc: Hannes Reinecke > > --- > > block/blk-mq-debugfs.c | 1 - > > block/blk-mq-sched.c | 3 --- > > include/linux/blkdev.h | 2 -- > > 3 files changed, 6 deletions(-) > > > > --- linux-5.11.orig/block/blk-mq-sched.c 2021-02-14 23:32:24.000000000 +0100 > > +++ linux-5.11/block/blk-mq-sched.c 2021-03-01 11:06:49.629077653 +0100 > > @@ -408,9 +408,6 @@ static bool blk_mq_sched_bypass_insert(s > > if ((rq->rq_flags & RQF_FLUSH_SEQ) || blk_rq_is_passthrough(rq)) > > return true; > > > > - if (has_sched) > > - rq->rq_flags |= RQF_SORTED; > > - > > return false; > > } > > Since that's the only reason why we are passing in 'has_sched', you should > kill that argument as well from the function and the single caller. Sorry, missed that. Surprised the compiler didn't warn. I'll post a v2 shortly. Thanks, -- Jean Delvare SUSE L3 Support