From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org,
Jeffle Xu <jefflexu@linux.alibaba.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, Hannes Reinecke <hare@suse.de>,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V4 07/12] block: prepare for supporting bio_list via other link
Date: Mon, 29 Mar 2021 23:26:17 +0800 [thread overview]
Message-ID: <20210329152622.173035-8-ming.lei@redhat.com> (raw)
In-Reply-To: <20210329152622.173035-1-ming.lei@redhat.com>
So far bio list helpers always use .bi_next to traverse the list, we
will support to link bios by other bio field.
Prepare for such support by adding a macro so that users can define
another helpers for linking bios by other bio field.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
include/linux/bio.h | 132 +++++++++++++++++++++++---------------------
1 file changed, 68 insertions(+), 64 deletions(-)
diff --git a/include/linux/bio.h b/include/linux/bio.h
index d0246c92a6e8..619edd26a6c0 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -608,75 +608,11 @@ static inline unsigned bio_list_size(const struct bio_list *bl)
return sz;
}
-static inline void bio_list_add(struct bio_list *bl, struct bio *bio)
-{
- bio->bi_next = NULL;
-
- if (bl->tail)
- bl->tail->bi_next = bio;
- else
- bl->head = bio;
-
- bl->tail = bio;
-}
-
-static inline void bio_list_add_head(struct bio_list *bl, struct bio *bio)
-{
- bio->bi_next = bl->head;
-
- bl->head = bio;
-
- if (!bl->tail)
- bl->tail = bio;
-}
-
-static inline void bio_list_merge(struct bio_list *bl, struct bio_list *bl2)
-{
- if (!bl2->head)
- return;
-
- if (bl->tail)
- bl->tail->bi_next = bl2->head;
- else
- bl->head = bl2->head;
-
- bl->tail = bl2->tail;
-}
-
-static inline void bio_list_merge_head(struct bio_list *bl,
- struct bio_list *bl2)
-{
- if (!bl2->head)
- return;
-
- if (bl->head)
- bl2->tail->bi_next = bl->head;
- else
- bl->tail = bl2->tail;
-
- bl->head = bl2->head;
-}
-
static inline struct bio *bio_list_peek(struct bio_list *bl)
{
return bl->head;
}
-static inline struct bio *bio_list_pop(struct bio_list *bl)
-{
- struct bio *bio = bl->head;
-
- if (bio) {
- bl->head = bl->head->bi_next;
- if (!bl->head)
- bl->tail = NULL;
-
- bio->bi_next = NULL;
- }
-
- return bio;
-}
-
static inline struct bio *bio_list_get(struct bio_list *bl)
{
struct bio *bio = bl->head;
@@ -686,6 +622,74 @@ static inline struct bio *bio_list_get(struct bio_list *bl)
return bio;
}
+#define BIO_LIST_HELPERS(_pre, link) \
+ \
+static inline void _pre##_add(struct bio_list *bl, struct bio *bio) \
+{ \
+ bio->bi_##link = NULL; \
+ \
+ if (bl->tail) \
+ bl->tail->bi_##link = bio; \
+ else \
+ bl->head = bio; \
+ \
+ bl->tail = bio; \
+} \
+ \
+static inline void _pre##_add_head(struct bio_list *bl, struct bio *bio) \
+{ \
+ bio->bi_##link = bl->head; \
+ \
+ bl->head = bio; \
+ \
+ if (!bl->tail) \
+ bl->tail = bio; \
+} \
+ \
+static inline void _pre##_merge(struct bio_list *bl, struct bio_list *bl2) \
+{ \
+ if (!bl2->head) \
+ return; \
+ \
+ if (bl->tail) \
+ bl->tail->bi_##link = bl2->head; \
+ else \
+ bl->head = bl2->head; \
+ \
+ bl->tail = bl2->tail; \
+} \
+ \
+static inline void _pre##_merge_head(struct bio_list *bl, \
+ struct bio_list *bl2) \
+{ \
+ if (!bl2->head) \
+ return; \
+ \
+ if (bl->head) \
+ bl2->tail->bi_##link = bl->head; \
+ else \
+ bl->tail = bl2->tail; \
+ \
+ bl->head = bl2->head; \
+} \
+ \
+static inline struct bio *_pre##_pop(struct bio_list *bl) \
+{ \
+ struct bio *bio = bl->head; \
+ \
+ if (bio) { \
+ bl->head = bl->head->bi_##link; \
+ if (!bl->head) \
+ bl->tail = NULL; \
+ \
+ bio->bi_##link = NULL; \
+ } \
+ \
+ return bio; \
+} \
+
+BIO_LIST_HELPERS(bio_list, next);
+
/*
* Increment chain count for the bio. Make sure the CHAIN flag update
* is visible before the raised count.
--
2.29.2
next prev parent reply other threads:[~2021-03-29 15:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 15:26 [PATCH V4 00/12] block: support bio based io polling Ming Lei
2021-03-29 15:26 ` [PATCH V4 01/12] block: add helper of blk_queue_poll Ming Lei
2021-03-29 15:26 ` [PATCH V4 02/12] block: add one helper to free io_context Ming Lei
2021-03-29 15:26 ` [PATCH V4 03/12] block: create io poll context for submission and poll task Ming Lei
2021-03-30 3:54 ` JeffleXu
2021-03-30 6:17 ` Hannes Reinecke
2021-03-29 15:26 ` [PATCH V4 04/12] block: add req flag of REQ_POLL_CTX Ming Lei
2021-03-30 6:19 ` Hannes Reinecke
2021-03-29 15:26 ` [PATCH V4 05/12] block: add new field into 'struct bvec_iter' Ming Lei
2021-03-29 15:26 ` [PATCH V4 06/12] block/mq: extract one helper function polling hw queue Ming Lei
2021-03-29 15:26 ` Ming Lei [this message]
2021-03-29 15:26 ` [PATCH V4 08/12] block: use per-task poll context to implement bio based io polling Ming Lei
2021-03-30 3:52 ` JeffleXu
2021-03-30 6:40 ` Hannes Reinecke
2021-03-30 8:32 ` Ming Lei
2021-03-29 15:26 ` [PATCH V4 09/12] blk-mq: limit hw queues to be polled in each blk_poll() Ming Lei
2021-03-30 3:53 ` JeffleXu
2021-03-29 15:26 ` [PATCH V4 10/12] block: add queue_to_disk() to get gendisk from request_queue Ming Lei
2021-03-30 6:27 ` Hannes Reinecke
2021-03-29 15:26 ` [PATCH V4 11/12] block: add poll_capable method to support bio-based IO polling Ming Lei
2021-03-30 6:26 ` Hannes Reinecke
2021-03-30 6:50 ` JeffleXu
2021-03-30 8:49 ` Ming Lei
2021-03-29 15:26 ` [PATCH V4 12/12] dm: support IO polling for bio-based dm device Ming Lei
2021-03-30 6:40 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329152622.173035-8-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox