From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BCBBC433ED for ; Thu, 15 Apr 2021 23:18:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D24FE61103 for ; Thu, 15 Apr 2021 23:18:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235064AbhDOXS4 (ORCPT ); Thu, 15 Apr 2021 19:18:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60216 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234735AbhDOXS4 (ORCPT ); Thu, 15 Apr 2021 19:18:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618528712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S7a+vZdjllcLmwLCMOcXS/rC/C8NhrGVBWb9YpbjGYg=; b=IVKgFfFouulwiuG64XBEaT3JtatKvyXEajyjJSVcYsIFThW5A5Q7XPTeCg+rhiSSYMjGpz vf2CwFRi7B+TPtkn6mbcOHkvR77VoDgxL5Z38uMQnXQYSkbQbRE0S4iPg99dxDP4TPU4Qs 4KvhgnrXUigYiws3SN9jcSQgbQEvxwY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-FnUT1tQuMHGmEEmrzNQi6A-1; Thu, 15 Apr 2021 19:18:20 -0400 X-MC-Unique: FnUT1tQuMHGmEEmrzNQi6A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B0A5F1854E27; Thu, 15 Apr 2021 23:18:19 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8631E62677; Thu, 15 Apr 2021 23:18:16 +0000 (UTC) Date: Thu, 15 Apr 2021 19:18:15 -0400 From: Mike Snitzer To: Christoph Hellwig , Jens Axboe Cc: dm-devel@redhat.com, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: nvme: Return BLK_STS_TARGET if the DNR bit is set Message-ID: <20210415231815.GA16047@redhat.com> References: <20210415231126.8746-1-snitzer@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210415231126.8746-1-snitzer@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Sorry, emailed from wrong terminal... have since emailed correct v2 On Thu, Apr 15 2021 at 7:11pm -0400, Mike Snitzer wrote: > BZ: 1948690 > Upstream Status: RHEL-only > > Signed-off-by: Mike Snitzer > > rhel-8.git commit ef4ab90c12db5e0e50800ec323736b95be7a6ff5 > Author: Mike Snitzer > Date: Tue Aug 25 21:52:45 2020 -0400 > > [nvme] nvme: Return BLK_STS_TARGET if the DNR bit is set > > Message-id: <20200825215248.2291-8-snitzer@redhat.com> > Patchwork-id: 325178 > Patchwork-instance: patchwork > O-Subject: [RHEL8.3 PATCH 07/10] nvme: Return BLK_STS_TARGET if the DNR bit is set > Bugzilla: 1843515 > RH-Acked-by: David Milburn > RH-Acked-by: Gopal Tiwari > RH-Acked-by: Ewan Milne > > BZ: 1843515 > Upstream Status: RHEL-only > > If the DNR bit is set we should not retry the command, even if > the standard status evaluation indicates so. > > SUSE is carrying this patch in their kernel: > https://lwn.net/Articles/800370/ > > Based on patch posted for upstream inclusion but rejected: > v1: https://lore.kernel.org/linux-nvme/20190806111036.113233-1-hare@suse.de/ > v2: https://lore.kernel.org/linux-nvme/20190807071208.101882-1-hare@suse.de/ > v2-keith: https://lore.kernel.org/linux-nvme/20190807144725.GB25621@localhost.localdomain/ > v3: https://lore.kernel.org/linux-nvme/20190812075147.79598-1-hare@suse.de/ > v3-keith: https://lore.kernel.org/linux-nvme/20190813141510.GB32686@localhost.localdomain/ > > This commit's change is basically "v3-keith". > > Signed-off-by: Mike Snitzer > Signed-off-by: Frantisek Hrbata > > --- > drivers/nvme/host/core.c | 3 +++ > 1 file changed, 3 insertions(+) > > Index: linux-rhel9/drivers/nvme/host/core.c > =================================================================== > --- linux-rhel9.orig/drivers/nvme/host/core.c > +++ linux-rhel9/drivers/nvme/host/core.c > @@ -237,6 +237,9 @@ static void nvme_delete_ctrl_sync(struct > > static blk_status_t nvme_error_status(u16 status) > { > + if (unlikely(status & NVME_SC_DNR)) > + return BLK_STS_TARGET; > + > switch (status & 0x7ff) { > case NVME_SC_SUCCESS: > return BLK_STS_OK;