From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Ming Lei <ming.lei@redhat.com>, linux-block@vger.kernel.org
Subject: Can we make the io_poll queue attibute read-only
Date: Thu, 29 Apr 2021 09:32:06 +0200 [thread overview]
Message-ID: <20210429073206.GA3925@lst.de> (raw)
Hi Jens,
while looking at the polling code I wonder if we have to keep supporting
the change of the io_poll attribute and thus the poll flag on a live
queue. The support to change this goes back to before supporting the
explicit poll queues, and was used as the prime interface to enable
polling. Now that we use explicit poll queues the driver specific
paramters to set them up work as the prime interface to enable polling.
They can still be changed at runtime, although much more invasively
(i.e. controller reset in nvme). The upside is that we don't need
to bother with draining the bios and two queue flags, and don't have
a confusing duplicated user interface.
next reply other threads:[~2021-04-29 7:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 7:32 Christoph Hellwig [this message]
2021-04-29 14:43 ` Can we make the io_poll queue attibute read-only Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429073206.GA3925@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).