Re: [PATCH 1/1] s390/dasd: add missing discipline function

[Cornelia Huck <cohuck@redhat.com>]

On Tue, 25 May 2021 14:50:06 +0200
Stefan Haberland <sth@linux.ibm.com> wrote:

> Fix crash with illegal operation exception in dasd_device_tasklet.
> Commit b72949328869 ("s390/dasd: Prepare for additional path event handling")
> renamed the verify_path function for ECKD but not for FBA and DIAG.
> This leads to a panic when the path verification function is called for a
> FBA or DIAG device.
> 
> Fix by defining a wrapper function for dasd_generic_verify_path().
> 
> Fixes: b72949328869 ("s390/dasd: Prepare for additional path event handling")
> 
> Cc: <stable@vger.kernel.org> #5.11
> Reviewed-by: Jan Hoeppner <hoeppner@linux.ibm.com>
> Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
> ---
>  drivers/s390/block/dasd_diag.c | 8 +++++++-
>  drivers/s390/block/dasd_fba.c  | 8 +++++++-
>  drivers/s390/block/dasd_int.h  | 1 -
>  3 files changed, 14 insertions(+), 3 deletions(-)

Oops.

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

[Just to satisfy my curiosity: are there still any FBA devices around,
other than z/VM emulating a DASD frontend for FCP devices?]