From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Adam Manzanares <adam.manzanares@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
Damien Le Moal <damien.lemoal@wdc.com>,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH 3/9] block/mq-deadline: Remove two local variables
Date: Wed, 26 May 2021 18:01:28 -0700 [thread overview]
Message-ID: <20210527010134.32448-4-bvanassche@acm.org> (raw)
In-Reply-To: <20210527010134.32448-1-bvanassche@acm.org>
Make __dd_dispatch_request() easier to read by removing two local
variables.
Cc: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
block/mq-deadline.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/block/mq-deadline.c b/block/mq-deadline.c
index 4da0bd3b9827..cc9d0fc72db2 100644
--- a/block/mq-deadline.c
+++ b/block/mq-deadline.c
@@ -276,7 +276,6 @@ deadline_next_request(struct deadline_data *dd, int data_dir)
static struct request *__dd_dispatch_request(struct deadline_data *dd)
{
struct request *rq, *next_rq;
- bool reads, writes;
int data_dir;
lockdep_assert_held(&dd->lock);
@@ -287,9 +286,6 @@ static struct request *__dd_dispatch_request(struct deadline_data *dd)
goto done;
}
- reads = !list_empty(&dd->fifo_list[READ]);
- writes = !list_empty(&dd->fifo_list[WRITE]);
-
/*
* batches are currently reads XOR writes
*/
@@ -306,7 +302,7 @@ static struct request *__dd_dispatch_request(struct deadline_data *dd)
* data direction (read / write)
*/
- if (reads) {
+ if (!list_empty(&dd->fifo_list[READ])) {
BUG_ON(RB_EMPTY_ROOT(&dd->sort_list[READ]));
if (deadline_fifo_request(dd, WRITE) &&
@@ -322,7 +318,7 @@ static struct request *__dd_dispatch_request(struct deadline_data *dd)
* there are either no reads or writes have been starved
*/
- if (writes) {
+ if (!list_empty(&dd->fifo_list[WRITE])) {
dispatch_writes:
BUG_ON(RB_EMPTY_ROOT(&dd->sort_list[WRITE]));
next prev parent reply other threads:[~2021-05-27 1:01 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 1:01 [PATCH 0/9] Improve I/O priority support Bart Van Assche
2021-05-27 1:01 ` [PATCH 1/9] block/mq-deadline: Add several comments Bart Van Assche
2021-05-27 3:03 ` Damien Le Moal
2021-05-27 6:45 ` Hannes Reinecke
2021-05-27 19:30 ` Bart Van Assche
2021-05-27 8:43 ` Johannes Thumshirn
2021-05-27 15:13 ` Himanshu Madhani
2021-05-27 1:01 ` [PATCH 2/9] block/mq-deadline: Add two lockdep_assert_held() statements Bart Van Assche
2021-05-27 2:25 ` Chaitanya Kulkarni
2021-05-27 3:09 ` Damien Le Moal
2021-05-27 6:46 ` Hannes Reinecke
2021-05-27 8:44 ` Johannes Thumshirn
2021-05-27 15:14 ` Himanshu Madhani
2021-05-27 1:01 ` Bart Van Assche [this message]
2021-05-27 2:26 ` [PATCH 3/9] block/mq-deadline: Remove two local variables Chaitanya Kulkarni
2021-05-27 3:11 ` Damien Le Moal
2021-05-27 6:46 ` Hannes Reinecke
2021-05-27 8:44 ` Johannes Thumshirn
2021-05-27 15:15 ` Himanshu Madhani
2021-05-27 1:01 ` [PATCH 4/9] block/mq-deadline: Rename dd_init_queue() and dd_exit_queue() Bart Van Assche
2021-05-27 2:27 ` Chaitanya Kulkarni
2021-05-27 3:13 ` Damien Le Moal
2021-05-27 19:33 ` Bart Van Assche
2021-05-27 6:47 ` Hannes Reinecke
2021-05-27 8:44 ` Johannes Thumshirn
2021-05-27 15:16 ` Himanshu Madhani
2021-05-27 1:01 ` [PATCH 5/9] block/mq-deadline: Improve compile-time argument checking Bart Van Assche
2021-05-27 2:28 ` Chaitanya Kulkarni
2021-05-27 3:24 ` Damien Le Moal
2021-05-27 19:38 ` Bart Van Assche
2021-05-28 1:42 ` Damien Le Moal
2021-05-27 6:48 ` Hannes Reinecke
2021-05-27 8:49 ` Johannes Thumshirn
2021-05-27 15:19 ` Himanshu Madhani
2021-05-27 1:01 ` [PATCH 6/9] block/mq-deadline: Reduce the read expiry time for non-rotational media Bart Van Assche
2021-05-27 2:30 ` Chaitanya Kulkarni
2021-05-27 3:27 ` Damien Le Moal
2021-05-27 19:43 ` Bart Van Assche
2021-05-27 6:52 ` Hannes Reinecke
2021-05-27 15:20 ` Himanshu Madhani
2021-05-27 1:01 ` [PATCH 7/9] block/mq-deadline: Reserve 25% of tags for synchronous requests Bart Van Assche
2021-05-27 3:33 ` Damien Le Moal
2021-05-27 20:00 ` Bart Van Assche
2021-05-27 6:54 ` Hannes Reinecke
2021-05-27 19:55 ` Bart Van Assche
2021-05-27 1:01 ` [PATCH 8/9] block/mq-deadline: Add I/O priority support Bart Van Assche
2021-05-27 3:48 ` Damien Le Moal
2021-05-27 20:12 ` Bart Van Assche
2021-05-27 7:07 ` Hannes Reinecke
2021-05-27 20:23 ` Bart Van Assche
2021-05-28 1:40 ` Damien Le Moal
2021-05-27 1:01 ` [PATCH 9/9] block/mq-deadline: Add cgroup support Bart Van Assche
2021-05-27 7:09 ` Hannes Reinecke
2021-05-27 6:25 ` [PATCH 0/9] Improve I/O priority support Wang Jianchao
2021-05-27 8:05 ` Wang Jianchao
2021-05-27 18:40 ` Bart Van Assche
2021-05-28 2:05 ` Wang Jianchao
2021-05-28 8:43 ` Paolo Valente
2021-05-28 16:28 ` Bart Van Assche
2021-05-27 8:56 ` Johannes Thumshirn
2021-05-27 17:23 ` Chaitanya Kulkarni
2021-05-27 19:00 ` Bart Van Assche
2021-05-27 17:58 ` Adam Manzanares
2021-05-27 18:53 ` Bart Van Assche
2021-05-27 22:45 ` Adam Manzanares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527010134.32448-4-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=adam.manzanares@wdc.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox