From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C74C07E96 for ; Tue, 6 Jul 2021 04:17:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D24B361973 for ; Tue, 6 Jul 2021 04:17:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229730AbhGFETo (ORCPT ); Tue, 6 Jul 2021 00:19:44 -0400 Received: from verein.lst.de ([213.95.11.211]:58972 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbhGFETo (ORCPT ); Tue, 6 Jul 2021 00:19:44 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 53A6E68BEB; Tue, 6 Jul 2021 06:17:04 +0200 (CEST) Date: Tue, 6 Jul 2021 06:17:04 +0200 From: Christoph Hellwig To: Guoqing Jiang Cc: axboe@kernel.dk, tim@cyberelk.net, hch@lst.de, linux-block@vger.kernel.org Subject: Re: [PATCH] pd: fix order of cleaning up the queue and freeing the tagset Message-ID: <20210706041704.GA11174@lst.de> References: <20210706010734.1356066-1-guoqing.jiang@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210706010734.1356066-1-guoqing.jiang@linux.dev> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Jul 06, 2021 at 09:07:34AM +0800, Guoqing Jiang wrote: > From: Guoqing Jiang > > We must release the queue before freeing the tagset. > > Fixes: 262d431f9000 ("pd: use blk_mq_alloc_disk and blk_cleanup_disk") > Signed-off-by: Guoqing Jiang Looks good, Reviewed-by: Christoph Hellwig