From: Pavel Machek <pavel@ucw.cz>
To: Ian Pilcher <arequipeno@gmail.com>
Cc: linux-block@vger.kernel.org, linux-leds@vger.kernel.org,
axboe@kernel.dk, linux-kernel@vger.kernel.org,
kernelnewbies@kernelnewbies.org
Subject: Re: [RFC PATCH v2 01/10] docs: Add block device LED trigger documentation
Date: Tue, 10 Aug 2021 15:49:04 +0200 [thread overview]
Message-ID: <20210810134904.GA28089@amd> (raw)
In-Reply-To: <20210809033217.1113444-2-arequipeno@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]
Hi!
> +++ b/Documentation/ABI/testing/sysfs-block
> @@ -316,3 +316,19 @@ Description:
> does not complete in this time then the block driver timeout
> handler is invoked. That timeout handler can decide to retry
> the request, to fail it or to start a device recovery strategy.
> +
> +What: /sys/block/<disk>/led
> +Date: August 2021
> +Contact: Ian Pilcher <arequipeno@gmail.com>
> +Description:
> + Set the LED associated with this block device (or show available
> + LEDs and the currently selected LED, if any).
> +
> + Reading the attribute will display the available LEDs (LEDs that
> + are associated with the blkdev LED trigger). The currently
> + selected LED is enclosed in square brackets. To clear the
> + device's LED association write 'none' (without the quotes) or
> + an empty string/line to the attribute.
> +
> + See Documentation/ABI/testing/sysfs-class-led-trigger-blkdev and
> + Documentation/block/blk-ledtrig.rst.)
I have to agree with Marek / Pali -- this is very strange interface.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-08-10 13:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 3:32 [RFC PATCH v2 00/10] Add configurable block device LED triggers Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 01/10] docs: Add block device LED trigger documentation Ian Pilcher
2021-08-10 13:49 ` Pavel Machek [this message]
2021-08-09 3:32 ` [RFC PATCH v2 02/10] block: Add file (blk-ledtrig.c) for block device LED trigger implementation Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 03/10] block: Add block device LED trigger fields to gendisk structure Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 04/10] block: Add functions to set & clear block device LEDs Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 05/10] block: Add block device sysfs attribute to set/clear/show LED Ian Pilcher
2021-08-09 4:21 ` Jackie Liu
2021-08-09 15:44 ` Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 06/10] block: Add activate and deactivate functions for block device LED trigger Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 07/10] block: Add sysfs attributes to LEDs associated with blkdev trigger Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 08/10] block: Add init function for block device LED trigger Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 09/10] block: Blink device LED (if any) when request is sent to its driver Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 10/10] block: Add config option to enable block device LED triggers Ian Pilcher
2021-08-09 18:56 ` [RFC PATCH v2 00/10] Add configurable " Marek Behún
2021-08-09 19:07 ` Pali Rohár
2021-08-09 19:54 ` Ian Pilcher
2021-08-09 22:43 ` Marek Behún
2021-08-09 23:50 ` Ian Pilcher
2021-08-10 6:35 ` Greg KH
2021-08-10 13:38 ` Marek Behún
2021-08-10 14:48 ` Greg KH
2021-08-10 15:55 ` Ian Pilcher
2021-08-10 16:24 ` Greg KH
2021-08-10 16:39 ` Marek Behún
2021-08-10 16:43 ` Ian Pilcher
2021-08-11 6:26 ` Christoph Hellwig
2021-08-11 10:50 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810134904.GA28089@amd \
--to=pavel@ucw.cz \
--cc=arequipeno@gmail.com \
--cc=axboe@kernel.dk \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).