Re: [PATCH 17/18] ledtrig-blkdev: Add mode (read/write/rw) sysfs attributue

Ian Pilcher
2021-09-04T21:01:59Z

On 9/4/21 12:57 AM, Greg KH wrote:
> Also, you are now allowing any user to spam the kernel log, this shold
> be a dev_dbg() call at the most, if it is even needed at all. Same for
> the other pr_info() call in this function, please remove them all.

Greg -

A bit of a "philosophical" question, if I may ...

Is allowing the root user to "spam" the kernel log really a concern?
(The permissions on the attribute don't allow non-root users to write
to it.)

As a system administrator working with a sysfs API (or writing udev
rules to do so), I know that I appreciate having a meaningful message in
the log when something doesn't work.

Given that only the root user can trigger these messages, would you be
OK with dev_info()?

--
========================================================================
In Soviet Russia, Google searches you!
========================================================================