From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Tejun Heo <tj@kernel.org>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 3/4] block: drain file system I/O on del_gendisk
Date: Thu, 23 Sep 2021 07:27:05 +0200 [thread overview]
Message-ID: <20210923052705.GA5314@lst.de> (raw)
In-Reply-To: <YUvZi2a0KjxEkiHo@T590>
On Thu, Sep 23, 2021 at 09:34:03AM +0800, Ming Lei wrote:
> > + set_bit(GD_DEAD, &disk->state);
> > set_capacity(disk, 0);
> >
> > + /*
> > + * Prevent new I/O from crossing bio_queue_enter().
> > + */
> > + blk_queue_start_drain(q);
> > + blk_mq_freeze_queue_wait(q);
> > +
> > + rq_qos_exit(q);
> > + blk_sync_queue(q);
> > + blk_flush_integrity();
> > + /*
> > + * Allow using passthrough request again after the queue is torn down.
> > + */
> > + blk_mq_unfreeze_queue(q);
>
> After blk_mq_unfreeze_queue() returns, blk_try_enter_queue() will return
> true, so new FS I/O from opened bdev still won't be blocked, right?
It won't be blocked by blk_mq_unfreeze_queue, but because the capacity
is set to 0 it still won't make it to the driver.
next prev parent reply other threads:[~2021-09-23 5:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 17:22 tear down file system I/O in del_gendisk v2 Christoph Hellwig
2021-09-22 17:22 ` [PATCH 1/4] block: factor out a blk_try_enter_queue helper Christoph Hellwig
2021-09-22 17:22 ` [PATCH 2/4] block: split bio_queue_enter from blk_queue_enter Christoph Hellwig
2021-09-22 17:22 ` [PATCH 3/4] block: drain file system I/O on del_gendisk Christoph Hellwig
2021-09-23 1:34 ` Ming Lei
2021-09-23 5:27 ` Christoph Hellwig [this message]
2021-09-23 6:39 ` Ming Lei
2021-09-27 12:04 ` Christoph Hellwig
2021-09-27 14:32 ` Ming Lei
2021-09-23 6:21 ` Hannes Reinecke
2021-09-22 17:22 ` [PATCH 4/4] block: keep q_usage_counter in atomic mode after del_gendisk Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2021-09-20 11:24 tear down file system I/O in del_gendisk Christoph Hellwig
2021-09-20 11:24 ` [PATCH 3/4] block: drain file system I/O on del_gendisk Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923052705.GA5314@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).