From: Ming Lei <ming.lei@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V3 6/7] lib/group_cpus: allow to group cpus in case of !CONFIG_SMP
Date: Tue, 28 Sep 2021 08:55:57 +0800 [thread overview]
Message-ID: <20210928005558.243352-7-ming.lei@redhat.com> (raw)
In-Reply-To: <20210928005558.243352-1-ming.lei@redhat.com>
Allows group_cpus_evenly() to be called in case of !CONFIG_SMP by simply
assigning all CPUs into the 1st group.
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
lib/Makefile | 2 +-
lib/group_cpus.c | 14 ++++++++++++++
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/lib/Makefile b/lib/Makefile
index ff1cbe4958a1..3dbdc7f01215 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -338,7 +338,7 @@ obj-$(CONFIG_SBITMAP) += sbitmap.o
obj-$(CONFIG_PARMAN) += parman.o
-obj-$(CONFIG_SMP) += group_cpus.o
+obj-y += group_cpus.o
# GCC library routines
obj-$(CONFIG_GENERIC_LIB_ASHLDI3) += ashldi3.o
diff --git a/lib/group_cpus.c b/lib/group_cpus.c
index f7165b38c9d0..b34f7d309f9c 100644
--- a/lib/group_cpus.c
+++ b/lib/group_cpus.c
@@ -327,6 +327,7 @@ static int __group_cpus_evenly(unsigned int startgrp, unsigned int numgrps,
return done;
}
+#ifdef CONFIG_SMP
/**
* group_cpus_evenly - Group all CPUs evenly per NUMA/CPU locality
* @numgrps: number of groups
@@ -411,4 +412,17 @@ struct cpumask *group_cpus_evenly(unsigned int numgrps)
}
return masks;
}
+#else
+struct cpumask *group_cpus_evenly(unsigned int numgrps)
+{
+ struct cpumask *masks = kcalloc(numgrps, sizeof(*masks), GFP_KERNEL);
+
+ if (!masks)
+ return NULL;
+
+ /* assign all CPUs(cpu 0) to the 1st group only */
+ cpumask_copy(&masks[0], cpu_possible_mask);
+ return masks;
+}
+#endif
EXPORT_SYMBOL_GPL(group_cpus_evenly);
--
2.31.1
next prev parent reply other threads:[~2021-09-28 0:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 0:55 [PATCH V3 0/7] genirq/affinity: abstract new API from managed irq affinity spread Ming Lei
2021-09-28 0:55 ` [PATCH V3 1/7] genirq/affinity: remove the 'firstvec' parameter from irq_build_affinity_masks Ming Lei
2021-09-28 0:55 ` [PATCH V3 2/7] genirq/affinity: pass affinity managed mask array to irq_build_affinity_masks Ming Lei
2021-09-28 0:55 ` [PATCH V3 3/7] genirq/affinity: don't pass irq_affinity_desc " Ming Lei
2021-09-28 0:55 ` [PATCH V3 4/7] genirq/affinity: rename irq_build_affinity_masks as group_cpus_evenly Ming Lei
2021-09-28 0:55 ` [PATCH V3 5/7] genirq/affinity: move group_cpus_evenly() into lib/ Ming Lei
2021-09-28 5:26 ` Christoph Hellwig
2021-09-29 14:40 ` John Garry
2021-09-30 0:05 ` Ming Lei
2021-09-28 0:55 ` Ming Lei [this message]
2021-09-28 5:27 ` [PATCH V3 6/7] lib/group_cpus: allow to group cpus in case of !CONFIG_SMP Christoph Hellwig
2021-09-28 0:55 ` [PATCH V3 7/7] blk-mq: build default queue map via group_cpus_evenly() Ming Lei
2021-09-28 5:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928005558.243352-7-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).