From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V2 0/5] blk-mq: support concurrent queue quiescing
Date: Thu, 30 Sep 2021 20:56:16 +0800 [thread overview]
Message-ID: <20210930125621.1161726-1-ming.lei@redhat.com> (raw)
Hello,
request queue quiescing has been applied in lots of block drivers and
block core from different/un-related code paths. So far, both quiesce
and unquiesce changes the queue state unconditionally. This way has
caused trouble, such as, driver is quiescing queue for its own purpose,
however block core's queue quiesce may come because of elevator switch,
updating nr_requests or other queue attributes, then un-expected
unquiesce may come too early.
It has been observed kernel panic when running stress test on dm-mpath
suspend and updating nr_requests.
Fix the issue by supporting concurrent queue quiescing. But nvme has very
complicated uses on quiesce/unquiesce, which two may not be called in
pairing, so switch to this way in patch 1~4, and patch 5 provides
nested queue quiesce.
V2:
- replace mutex with atomic ops for supporting paring quiesce &
unquiesce
Ming Lei (5):
nvme: add APIs for stopping/starting admin queue
nvme: apply nvme API to quiesce/unquiesce admin queue
nvme: prepare for pairing quiescing and unquiescing
nvme: paring quiesce/unquiesce
blk-mq: support concurrent queue quiesce/unquiesce
block/blk-mq.c | 20 +++++++++--
drivers/nvme/host/core.c | 70 ++++++++++++++++++++++++++------------
drivers/nvme/host/fc.c | 8 ++---
drivers/nvme/host/nvme.h | 4 +++
drivers/nvme/host/pci.c | 8 ++---
drivers/nvme/host/rdma.c | 14 ++++----
drivers/nvme/host/tcp.c | 16 ++++-----
drivers/nvme/target/loop.c | 4 +--
include/linux/blkdev.h | 2 ++
9 files changed, 96 insertions(+), 50 deletions(-)
--
2.31.1
next reply other threads:[~2021-09-30 12:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 12:56 Ming Lei [this message]
2021-09-30 12:56 ` [PATCH V2 1/5] nvme: add APIs for stopping/starting admin queue Ming Lei
2021-10-01 5:56 ` Chaitanya Kulkarni
2021-10-05 2:23 ` Ming Lei
2021-10-05 3:38 ` Chaitanya Kulkarni
2021-10-05 8:04 ` Ming Lei
2021-10-11 11:39 ` Christoph Hellwig
2021-10-13 4:25 ` Chaitanya Kulkarni
2021-09-30 12:56 ` [PATCH V2 2/5] nvme: apply nvme API to quiesce/unquiesce " Ming Lei
2021-10-01 5:57 ` Chaitanya Kulkarni
2021-09-30 12:56 ` [PATCH V2 3/5] nvme: prepare for pairing quiescing and unquiescing Ming Lei
2021-09-30 12:56 ` [PATCH V2 4/5] nvme: paring quiesce/unquiesce Ming Lei
2021-09-30 12:56 ` [PATCH V2 5/5] blk-mq: support concurrent queue quiesce/unquiesce Ming Lei
2021-09-30 15:56 ` Bart Van Assche
2021-10-05 2:31 ` Ming Lei
2021-10-08 3:22 ` yukuai (C)
2021-10-08 5:10 ` Ming Lei
2021-10-08 6:22 ` yukuai (C)
2021-10-08 6:35 ` Ming Lei
2021-10-08 7:13 ` yukuai (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210930125621.1161726-1-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).