linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
	Bart Van Assche <bvanassche@acm.org>,
	Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V3 5/6] nvme: loop: clear NVME_CTRL_ADMIN_Q_STOPPED after admin queue is reallocated
Date: Sat,  9 Oct 2021 11:47:12 +0800	[thread overview]
Message-ID: <20211009034713.1489183-6-ming.lei@redhat.com> (raw)
In-Reply-To: <20211009034713.1489183-1-ming.lei@redhat.com>

The nvme-loop's admin queue may be freed and reallocated, and we have to
reset the flag of NVME_CTRL_ADMIN_Q_STOPPED so that the flag can match
with the quiesce state of the admin queue.

nvme-loop is the only driver to reallocate request queue, and not see
such usage in other nvme drivers.

Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
 drivers/nvme/target/loop.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/target/loop.c b/drivers/nvme/target/loop.c
index 440e1544033b..eb1094254c82 100644
--- a/drivers/nvme/target/loop.c
+++ b/drivers/nvme/target/loop.c
@@ -384,6 +384,8 @@ static int nvme_loop_configure_admin_queue(struct nvme_loop_ctrl *ctrl)
 		error = PTR_ERR(ctrl->ctrl.admin_q);
 		goto out_cleanup_fabrics_q;
 	}
+	/* reset stopped state for the fresh admin queue */
+	clear_bit(NVME_CTRL_ADMIN_Q_STOPPED, &ctrl->ctrl.flags);
 
 	error = nvmf_connect_admin_queue(&ctrl->ctrl);
 	if (error)
-- 
2.31.1


  parent reply	other threads:[~2021-10-09  3:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09  3:47 [PATCH V3 0/6] blk-mq: support concurrent queue quiescing Ming Lei
2021-10-09  3:47 ` [PATCH V3 1/6] nvme: add APIs for stopping/starting admin queue Ming Lei
2021-10-09  3:47 ` [PATCH V3 2/6] nvme: apply nvme API to quiesce/unquiesce " Ming Lei
2021-10-09  3:47 ` [PATCH V3 3/6] nvme: prepare for pairing quiescing and unquiescing Ming Lei
2021-10-09  3:47 ` [PATCH V3 4/6] nvme: paring quiesce/unquiesce Ming Lei
2021-10-12 10:36   ` Christoph Hellwig
2021-10-12 15:01     ` Ming Lei
2021-10-12 15:07       ` Christoph Hellwig
2021-10-12 15:17         ` Ming Lei
2021-10-13 12:23           ` Sagi Grimberg
2021-10-09  3:47 ` Ming Lei [this message]
2021-10-09  3:47 ` [PATCH V3 6/6] blk-mq: support concurrent queue quiesce/unquiesce Ming Lei
2021-10-12 10:30   ` Christoph Hellwig
2021-10-12 15:06     ` Ming Lei
2021-10-12 15:08       ` Christoph Hellwig
2021-10-12 15:13         ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211009034713.1489183-6-ming.lei@redhat.com \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=chaitanyak@nvidia.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).