Re: [PATCH v3] loop: don't print warnings if the underlying filesystem doesn't support discard

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2862 bytes --]

Hi Mikulas,

I love your patch! Yet something to improve:

[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on kdave/for-next ceph-client/for-linus cifs/for-next tytso-ext4/dev jaegeuk-f2fs/dev-test mszeredi-fuse/for-next linus/master v5.15-rc5 next-20211012]
[cannot apply to hch-configfs/for-next gfs2/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mikulas-Patocka/loop-don-t-print-warnings-if-the-underlying-filesystem-doesn-t-support-discard/20211013-042727
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: arc-randconfig-r043-20211012 (attached as .config)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c381403746bc0dc3eb5db4b157408430febd6ecf
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mikulas-Patocka/loop-don-t-print-warnings-if-the-underlying-filesystem-doesn-t-support-discard/20211013-042727
        git checkout c381403746bc0dc3eb5db4b157408430febd6ecf
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash fs/fuse/ fs/overlayfs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> fs/overlayfs/file.c:661:38: error: 'FALLOC_FL_SUPPORTED_MASK' undeclared here (not in a function)
     661 |         .fallocate_supported_flags = FALLOC_FL_SUPPORTED_MASK,
         |                                      ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/FALLOC_FL_SUPPORTED_MASK +661 fs/overlayfs/file.c

   651	
   652	const struct file_operations ovl_file_operations = {
   653		.open		= ovl_open,
   654		.release	= ovl_release,
   655		.llseek		= ovl_llseek,
   656		.read_iter	= ovl_read_iter,
   657		.write_iter	= ovl_write_iter,
   658		.fsync		= ovl_fsync,
   659		.mmap		= ovl_mmap,
   660		.fallocate	= ovl_fallocate,
 > 661		.fallocate_supported_flags = FALLOC_FL_SUPPORTED_MASK,
   662		.fadvise	= ovl_fadvise,
   663		.flush		= ovl_flush,
   664		.splice_read    = generic_file_splice_read,
   665		.splice_write   = ovl_splice_write,
   666	
   667		.copy_file_range	= ovl_copy_file_range,
   668		.remap_file_range	= ovl_remap_file_range,
   669	};
   670	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33898 bytes --]