From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: please revert the UFS HPB support
Date: Thu, 21 Oct 2021 17:15:20 +0200 [thread overview]
Message-ID: <20211021151520.GA31407@lst.de> (raw)
In-Reply-To: <84fac5a3-135a-2ac8-5929-a1031a311cb7@kernel.dk>
On Thu, Oct 21, 2021 at 09:13:30AM -0600, Jens Axboe wrote:
> On 10/21/21 8:42 AM, Christoph Hellwig wrote:
> > Hi Martin,
> >
> > I just noticed the UFS HPB support landed in 5.15, and just as
> > before it is completely broken by allocating another request on
> > the same device and then reinserting it in the queue. It is bad
> > enough that we have to live with blk_insert_cloned_request for
> > dm-mpath, but this is too big of an API abuse to make it into
> > a release. We need to drop this code ASAP, and I can prepare
> > a patch for that.
>
> That sounds awful, do you have a link to the offending commit(s)?
I'll need to look for it, busy in calls right now, but just grep for
blk_insert_cloned_request.
next prev parent reply other threads:[~2021-10-21 15:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 14:42 please revert the UFS HPB support Christoph Hellwig
2021-10-21 15:13 ` Jens Axboe
2021-10-21 15:15 ` Christoph Hellwig [this message]
2021-10-21 15:17 ` Christoph Hellwig
2021-10-21 16:22 ` Bart Van Assche
2021-10-23 15:43 ` James Bottomley
2021-10-25 5:16 ` Daejun Park
2021-10-25 7:07 ` Christoph Hellwig
2021-10-25 11:39 ` James Bottomley
2021-10-23 1:54 ` Martin K. Petersen
2021-10-23 4:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021151520.GA31407@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox