From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Jaegeuk Kim <jaegeuk@kernel.org>,
alim.akhtar@samsung.com, avri.altman@wdc.com,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: mark HPB support as BROKEN
Date: Wed, 27 Oct 2021 07:27:24 +0200 [thread overview]
Message-ID: <20211027052724.GA8946@lst.de> (raw)
In-Reply-To: <679b4d3b-778e-47cd-d53f-f7bf77315f7c@acm.org>
On Tue, Oct 26, 2021 at 01:10:47PM -0700, Bart Van Assche wrote:
> If blk_insert_cloned_request() is moved into the device mapper then I
> think that blk_mq_request_issue_directly() will need to be exported.
Which is even worse.
> How
> about the (totally untested) patch below for removing the
> blk_insert_cloned_request() call from the UFS-HPB code?
Which again doesn't fix anything. The problem is that it fans out one
request into two on the same queue, not the specific interface used.
Martin: please just take the HPB removal. This seems to be the only
thing that makes sense given that no one from the UFS camp seems to
have the time and resources to come up with an alternative.
next prev parent reply other threads:[~2021-10-27 5:27 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 7:12 [PATCH] scsi: ufs: mark HPB support as BROKEN Christoph Hellwig
2021-10-26 7:18 ` Hannes Reinecke
2021-10-26 7:24 ` Damien Le Moal
2021-10-26 13:04 ` James Bottomley
2021-10-26 16:36 ` Bart Van Assche
2021-10-26 17:19 ` James Bottomley
2021-10-26 17:25 ` Jens Axboe
2021-10-26 18:05 ` Bart Van Assche
2021-10-26 18:10 ` Jens Axboe
2021-10-26 18:18 ` James Bottomley
2021-10-26 18:27 ` Martin K. Petersen
2021-10-26 20:10 ` Bart Van Assche
2021-10-26 22:22 ` Daejun Park
2021-10-27 5:27 ` Christoph Hellwig [this message]
2021-10-27 12:20 ` James Bottomley
2021-10-28 20:21 ` Bart Van Assche
2021-10-28 20:33 ` James Bottomley
2021-10-28 20:53 ` Bart Van Assche
2021-10-28 21:14 ` Daejun Park
2021-10-27 13:16 ` Bart Van Assche
2021-10-27 14:12 ` Keith Busch
2021-10-27 14:38 ` Jens Axboe
2021-10-27 14:43 ` James Bottomley
2021-10-27 15:03 ` Ming Lei
2021-10-27 15:06 ` Jens Axboe
2021-10-27 15:16 ` Ming Lei
2021-10-27 15:44 ` Martin K. Petersen
2021-10-27 15:58 ` Ming Lei
2021-10-27 16:16 ` Keith Busch
2021-10-27 16:19 ` Jens Axboe
2021-10-28 0:42 ` Ming Lei
2021-10-28 1:10 ` Daejun Park
2021-10-28 2:07 ` Ming Lei
2021-10-27 16:59 ` Martin K. Petersen
2021-10-27 15:35 ` Martin K. Petersen
2021-10-27 15:40 ` Jens Axboe
2021-10-27 16:16 ` Martin K. Petersen
2021-10-27 17:01 ` Bart Van Assche
2021-10-28 1:32 ` Ming Lei
2021-10-29 10:53 ` Christoph Hellwig
2021-10-29 11:39 ` James Bottomley
2021-10-29 13:35 ` Avri Altman
2021-10-29 13:44 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027052724.GA8946@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox